From 8584aae8666d20ef50ce3cdea5b71fed89c6ff97 Mon Sep 17 00:00:00 2001 From: Chris Dodge Date: Tue, 23 Jul 2013 15:30:32 -0400 Subject: [PATCH] It seems like self.tabs is getting set to an empty set [] now rather than None. This causes the tab defaulting to not populate, leading to crashes in the LMS if someone makes a new course with additional tabs (e.g. static tabs or pdf-textbooks) --- common/lib/xmodule/xmodule/course_module.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/lib/xmodule/xmodule/course_module.py b/common/lib/xmodule/xmodule/course_module.py index d597221dec..1f74b6c7a9 100644 --- a/common/lib/xmodule/xmodule/course_module.py +++ b/common/lib/xmodule/xmodule/course_module.py @@ -410,7 +410,7 @@ class CourseDescriptor(CourseFields, SequenceDescriptor): continue # TODO check that this is still needed here and can't be by defaults. - if self.tabs is None: + if not self.tabs or (isinstance(self.tabs, list) and len(self.tabs) == 0): # When calling the various _tab methods, can omit the 'type':'blah' from the # first arg, since that's only used for dispatch tabs = []