Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

OpaqueKey copy and deepcopy are identity ops

Browse Source 
because keys are immutable
This commit is contained in:
Don Mitchell
2014-06-04 11:11:09 -04:00
committed by Sarina Canelake
parent 2c6437a279
commit 84ee2b19f2
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
common/lib/opaque_keys/opaque_keys/__init__.py
View File

@@ -187,12 +187,17 @@ class OpaqueKey(object):
return self.NAMESPACE_SEPARATOR.join([self.CANONICAL_NAMESPACE, self._to_string()]) # pylint: disable=no-member return self.NAMESPACE_SEPARATOR.join([self.CANONICAL_NAMESPACE, self._to_string()]) # pylint: disable=no-member
def __copy__(self): def __copy__(self):
return self.replace() """
Because it's immutable, return itself
"""
return self
def __deepcopy__(self, memo): def __deepcopy__(self, memo):
return self.replace(**{ """
key: deepcopy(getattr(self, key), memo) for key in self.KEY_FIELDS # pylint: disable=no-member Because it's immutable, return itself
}) """
memo[id(self)] = self
return self
def __setstate__(self, state_dict): def __setstate__(self, state_dict):
# used by pickle to set fields on an unpickled object # used by pickle to set fields on an unpickled object

3
common/lib/opaque_keys/opaque_keys/tests/test_opaque_keys.py
View File

@@ -136,12 +136,9 @@ class KeyTests(TestCase):
deep = copy.deepcopy(original) deep = copy.deepcopy(original)
self.assertEquals(original, copied) self.assertEquals(original, copied)
self.assertNotEquals(id(original), id(copied))
self.assertEquals(id(original.value), id(copied.value)) self.assertEquals(id(original.value), id(copied.value))
self.assertEquals(original, deep) self.assertEquals(original, deep)
self.assertNotEquals(id(original), id(deep))
self.assertNotEquals(id(original.value), id(deep.value))
self.assertEquals(copy.deepcopy([original]), [original]) self.assertEquals(copy.deepcopy([original]), [original])