chore: apply amnesty on existing not fixable issues (#32215)

* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint line around directives issue

* fix: eslint semi rule

* fix: eslint newline per chain rule

* fix: eslint space infix ops rule

* fix: eslint space-in-parens issue

* fix: eslint space before function paren issue

* fix: eslint space before blocks issue

* fix: eslint arrow body style issue

* fix: eslint dot-location issue

* fix: eslint quotes issue

* fix: eslint quote props issue

* fix: eslint operator assignment issue

* fix: eslint new line after import issue

* fix: indent issues

* fix: operator assignment issue

* fix: all autofixable eslint issues

* fix: all react related fixable issues

* fix: autofixable eslint issues

* chore: remove all template literals

* fix: remaining autofixable issues

* chore: apply amnesty on all existing issues

* fix: failing xss-lint issues

* refactor: apply amnesty on remaining issues

* refactor: apply amnesty on new issues

* fix: remove file level suppressions

* refactor: apply amnesty on new issues

xmodule/js/spec/video/events_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('VideoPlayer Events', function() {
         var state, oldOTBD;

xmodule/js/spec/video/general_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('Video', function() {
         afterEach(function() {
@@ -167,6 +168,7 @@
                 itFabrique(test.itDescription, test.data, test.expectData);
             });
 
+            // eslint-disable-next-line no-useless-return
             return;
 
             function itFabrique(itDescription, data, expectData) {

xmodule/js/spec/video/html5_video_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('Video HTML5Video', function() {
         var STATUS = window.STATUS;
@@ -213,6 +214,7 @@
                     });
 
                     it('set new incorrect values', function() {
+                        // eslint-disable-next-line no-shadow
                         var seek = state.videoPlayer.player.video.currentTime;
                         state.videoPlayer.player.seekTo(-50);
                         expect(state.videoPlayer.player.getCurrentTime()).toBe(seek);
@@ -264,6 +266,7 @@
                 });
 
                 it('getVolume', function() {
+                    // eslint-disable-next-line no-multi-assign
                     volume = state.videoPlayer.player.video.volume = 0.5;
                     expect(state.videoPlayer.player.getVolume()).toBe(volume);
                 });

xmodule/js/spec/video/resizer_spec.js

@@ -35,6 +35,7 @@
 
                 it('When Initialize without required parameters, log message is shown',
                     function() {
+                        // eslint-disable-next-line no-new
                         new Resizer({ });
                         expect(console.log).toHaveBeenCalled();
                     }

xmodule/js/spec/video/social_share_spec.js

@@ -1,4 +1,5 @@
 (function() {
+    // eslint-disable-next-line lines-around-directive
     'use strict';
 
     describe('VideoSocialSharingHandler', function() {
@@ -13,11 +14,15 @@
 
         describe('clicking social share fires an analytics event', function() {
             const testCases = [
-                {source: 'twitter'},
-                {source: 'facebook'},
-                {source: 'linkedin'},
+                // eslint-disable-next-line object-curly-spacing
+                { source: 'twitter' },
+                // eslint-disable-next-line object-curly-spacing
+                { source: 'facebook' },
+                // eslint-disable-next-line object-curly-spacing
+                { source: 'linkedin' },
             ];
-            _.each(testCases, ({source}) => {
+            // eslint-disable-next-line object-curly-spacing
+            _.each(testCases, ({ source }) => {
                 it(source, () => {
                     var siteShareButton = $(`.social-share-link[data-source="${source}"]`);
                     expect(siteShareButton.length).toEqual(1);

xmodule/js/spec/video/video_bumper_spec.js

@@ -4,6 +4,7 @@
     describe('VideoBumper', function() {
         var state, oldOTBD, waitForPlaying;
 
+        // eslint-disable-next-line no-shadow
         waitForPlaying = function(state, done) {
             jasmine.waitUntil(function() {
                 return state.el.hasClass('is-playing');

xmodule/js/spec/video/video_caption_spec.js

@@ -137,6 +137,7 @@
                         expect($.ajaxWithPrefix).toHaveBeenCalledWith({
                             url: transcriptURL,
                             notifyOnError: false,
+                            // eslint-disable-next-line no-void
                             data: void 0,
                             success: jasmine.any(Function),
                             error: jasmine.any(Function)

xmodule/js/spec/video/video_context_menu_spec.js

@@ -22,24 +22,28 @@
             return $.Event('keydown', {keyCode: key});
         };
 
+        // eslint-disable-next-line no-shadow
         openSubmenuMouse = function(menuSubmenuItem) {
             menuSubmenuItem.mouseover();
             jasmine.clock().tick(200);
             expect(menuSubmenuItem).toHaveClass('is-opened');
         };
 
+        // eslint-disable-next-line no-shadow
         openSubmenuKeyboard = function(menuSubmenuItem, keyCode) {
             menuSubmenuItem.focus().trigger(keyPressEvent(keyCode || $.ui.keyCode.RIGHT));
             expect(menuSubmenuItem).toHaveClass('is-opened');
             expect(menuSubmenuItem.children().last().children().first()).toBeFocused();
         };
 
+        // eslint-disable-next-line no-shadow
         closeSubmenuMouse = function(menuSubmenuItem) {
             menuSubmenuItem.mouseleave();
             jasmine.clock().tick(200);
             expect(menuSubmenuItem).not.toHaveClass('is-opened');
         };
 
+        // eslint-disable-next-line no-shadow
         closeSubmenuKeyboard = function(menuSubmenuItem) {
             menuSubmenuItem.children().first().focus().trigger(keyPressEvent($.ui.keyCode.LEFT));
             expect(menuSubmenuItem).not.toHaveClass('is-opened');

xmodule/js/spec/video/video_events_bumper_plugin_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     'use strict';
 

xmodule/js/spec/video/video_events_plugin_spec.js

@@ -1,5 +1,6 @@
 import '../helper.js';
 
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     'use strict';
 

xmodule/js/spec/video/video_focus_grabber_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('Video FocusGrabber', function() {
         var state;

xmodule/js/spec/video/video_player_spec.js

@@ -1,5 +1,6 @@
 /* global YT */
 
+// eslint-disable-next-line no-shadow-restricted-names
 (function(require, define, undefined) {
     'use strict';
 
@@ -157,6 +158,7 @@
                     });
 
                     describe('when not on a touch based device', function() {
+                        // eslint-disable-next-line no-shadow
                         var oldOTBD;
 
                         beforeEach(function() {

xmodule/js/spec/video/video_progress_slider_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('VideoProgressSlider', function() {
         var state, oldOTBD;

xmodule/js/spec/video/video_quality_control_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     describe('VideoQualityControl', function() {
         var state, qualityControl, videoPlayer, player;

xmodule/js/spec/video/video_save_state_plugin_spec.js

@@ -1,5 +1,6 @@
 import * as Time from 'time.js';
 
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     'use strict';
 

xmodule/js/spec/video/video_speed_control_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(undefined) {
     'use strict';
 

xmodule/js/spec/video/video_storage_spec.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(require, define, undefined) {
     require(
         ['video/00_video_storage.js'],
@@ -52,6 +53,7 @@
                     });
 
                     it('getItem', function() {
+                        // eslint-disable-next-line no-shadow
                         var data = window[namespace],
                             getItem = storage.getItem;
 
@@ -61,6 +63,7 @@
                     });
 
                     it('removeItem', function() {
+                        // eslint-disable-next-line no-shadow
                         var data = window[namespace],
                             removeItem = storage.removeItem;