chore: apply amnesty on existing not fixable issues (#32215)

* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint line around directives issue

* fix: eslint semi rule

* fix: eslint newline per chain rule

* fix: eslint space infix ops rule

* fix: eslint space-in-parens issue

* fix: eslint space before function paren issue

* fix: eslint space before blocks issue

* fix: eslint arrow body style issue

* fix: eslint dot-location issue

* fix: eslint quotes issue

* fix: eslint quote props issue

* fix: eslint operator assignment issue

* fix: eslint new line after import issue

* fix: indent issues

* fix: operator assignment issue

* fix: all autofixable eslint issues

* fix: all react related fixable issues

* fix: autofixable eslint issues

* chore: remove all template literals

* fix: remaining autofixable issues

* chore: apply amnesty on all existing issues

* fix: failing xss-lint issues

* refactor: apply amnesty on remaining issues

* refactor: apply amnesty on new issues

* fix: remove file level suppressions

* refactor: apply amnesty on new issues

lms/static/js/edxnotes/collections/tabs.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/models/tab.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/plugins/caret_navigation.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/plugins/events.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/plugins/scroller.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/plugins/store_error_handler.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/utils/logger.js

@@ -58,11 +58,13 @@
             if (!this.logLevel) {
                 return false;
             }
+            // eslint-disable-next-line prefer-spread
             this.updateHistory.apply(this, arguments);
             // Adds ID at the first place
             Array.prototype.unshift.call(args, this.id);
             if (console && console[logType]) {
                 if (console[logType].apply) {
+                    // eslint-disable-next-line prefer-spread
                     console[logType].apply(console, args);
                 } else { // Do this for IE
                     console[logType](args.join(' '));
@@ -136,6 +138,7 @@
             if (timeout) {
                 args.push(null, {timeout: timeout});
             }
+            // eslint-disable-next-line prefer-spread
             return Logger.log.apply(Logger, args);
         };
 

lms/static/js/edxnotes/utils/template.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/utils/utils.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/note_group.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/note_item.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/notes_factory.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 
@@ -61,6 +62,7 @@
      * @param {Array} plugins A list of plugins for the annotator.
      * @param {Object} options An options for the annotator.
      * */
+        // eslint-disable-next-line no-shadow
         setupPlugins = function(annotator, plugins, options) {
             _.each(plugins, function(plugin) {
                 var settings = options[plugin.toLowerCase()];

lms/static/js/edxnotes/views/notes_page.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/notes_visibility_factory.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/page_factory.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/search_box.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 
@@ -124,6 +125,7 @@
                 if (jXHR.responseText) {
                     try {
                         message = $.parseJSON(jXHR.responseText).error;
+                    // eslint-disable-next-line no-empty
                     } catch (error) { }
                 }
 

lms/static/js/edxnotes/views/shim.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tab_item.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tab_panel.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tab_view.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tabs/course_structure.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 
@@ -22,6 +23,7 @@
                                 sectionView;
                             if (sectionInfo) {
                                 sectionView = chapterView.addChild(sectionInfo);
+                                // eslint-disable-next-line no-shadow
                                 _.each(sectionInfo.children, function(location) {
                                     var notes = courseStructure.units[location];
                                     if (notes) {

lms/static/js/edxnotes/views/tabs/recent_activity.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tabs/search_results.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/tabs/tags.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 
@@ -94,6 +95,7 @@
 
                     _.each(sortedTagNames, function(tagName) {
                         noteGroup = notesByTag[tagName];
+                        // eslint-disable-next-line no-shadow
                         var tagTitle = interpolate_text(
                             '{tagName} ({numberOfNotesWithTag})',
                             {tagName: tagName, numberOfNotesWithTag: noteGroup.length}

lms/static/js/edxnotes/views/tabs_list.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';
 

lms/static/js/edxnotes/views/visibility_decorator.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-shadow-restricted-names
 (function(define, undefined) {
     'use strict';