Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore: apply amnesty on existing not fixable issues (#32215)

Browse Source 
* fix: eslint operator-linebreak issue

* fix: eslint quotes issue

* fix: react jsx indent and props issues

* fix: eslint trailing spaces issues

* fix: eslint line around directives issue

* fix: eslint semi rule

* fix: eslint newline per chain rule

* fix: eslint space infix ops rule

* fix: eslint space-in-parens issue

* fix: eslint space before function paren issue

* fix: eslint space before blocks issue

* fix: eslint arrow body style issue

* fix: eslint dot-location issue

* fix: eslint quotes issue

* fix: eslint quote props issue

* fix: eslint operator assignment issue

* fix: eslint new line after import issue

* fix: indent issues

* fix: operator assignment issue

* fix: all autofixable eslint issues

* fix: all react related fixable issues

* fix: autofixable eslint issues

* chore: remove all template literals

* fix: remaining autofixable issues

* chore: apply amnesty on all existing issues

* fix: failing xss-lint issues

* refactor: apply amnesty on remaining issues

* refactor: apply amnesty on new issues

* fix: remove file level suppressions

* refactor: apply amnesty on new issues
This commit is contained in:
Syed Ali Abbas Zaidi
2023-08-07 19:13:19 +05:00
committed by GitHub
parent e94af3c2d3
commit 8480dbc228
305 changed files with 1043 additions and 202 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
common/static/js/capa/src/jschannel.js
View File

@@ -233,7 +233,9 @@ var Channel = (function() {
if (origin === '*') {
// we must check all other origins, sadly.
for (var k in s_boundChans) {
// eslint-disable-next-line no-continue
if (!s_boundChans.hasOwnProperty(k)) { continue; }
// eslint-disable-next-line no-continue
if (k === '*') { continue; }
if (typeof s_boundChans[k][scope] === 'object') {
exists = hasWin(s_boundChans[k][scope]);
@@ -288,6 +290,7 @@ var Channel = (function() {
try {
var m = JSON.parse(e.data);
if (typeof m !== 'object' || m === null) { throw 'malformed'; }
// eslint-disable-next-line no-shadow
} catch (e) {
// just ignore any posted messages that do not consist of valid JSON
return;
@@ -387,6 +390,7 @@ var Channel = (function() {
var debug = function(m) {
if (cfg.debugOutput && window.console && window.console.log) {
// try to stringify, if it doesn't work we'll let javascript's built in toString do its magic
// eslint-disable-next-line no-empty
try { if (typeof m !== 'string') { m = JSON.stringify(m); } } catch (e) { }
console.log('[' + chanId + '] ' + m);
}
@@ -415,6 +419,7 @@ var Channel = (function() {
// eslint-disable-next-line brace-style
if (cfg.origin === '*') { validOrigin = true; }
// allow valid domains under http and https. Also, trim paths off otherwise valid origins.
// eslint-disable-next-line no-cond-assign
else if ((oMatch = cfg.origin.match(/^https?:\/\/(?:[-a-zA-Z0-9_\.])+(?::\d+)?/)) !== null) {
cfg.origin = oMatch[0].toLowerCase();
validOrigin = true;
@@ -541,6 +546,7 @@ var Channel = (function() {
if (typeof obj[cp] !== 'object') { obj[cp] = { }; }
obj = obj[cp];
}
// eslint-disable-next-line no-loop-func
obj[pathItems[pathItems.length - 1]] = (function() {
var cbName = path;
return function(params) {
@@ -569,6 +575,7 @@ var Channel = (function() {
// * if it's an object then we'll look form error and message parameters
else if (typeof e.error === 'string') {
error = e.error;
// eslint-disable-next-line no-ex-assign
if (!e.message) { message = ''; } else if (typeof e.message === 'string') { message = e.message; } else { e = e.message; } // let the stringify/toString message give us a reasonable verbose error string
}
}
@@ -707,6 +714,7 @@ var Channel = (function() {
var callbackNames = [];
var seen = [];
// eslint-disable-next-line no-shadow
var pruneFunctions = function(path, obj) {
if (seen.indexOf(obj) >= 0) {
throw 'params cannot be a recursive data structure';
@@ -715,6 +723,7 @@ var Channel = (function() {
if (typeof obj === 'object') {
for (var k in obj) {
// eslint-disable-next-line no-continue
if (!obj.hasOwnProperty(k)) { continue; }
var np = path + (path.length ? '/' : '') + k;
if (typeof obj[k] === 'function') {

3
common/static/js/capa/src/jsinput.js
View File

@@ -6,6 +6,7 @@
* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Same_origin_policy_for_JavaScript
*/
// eslint-disable-next-line no-shadow-restricted-names
var JSInput = (function($, undefined) {
// Initialize js inputs on current page.
// N.B.: No library assumptions about the iframe can be made (including,
@@ -102,6 +103,7 @@ var JSInput = (function($, undefined) {
channel.call({
method: 'getState',
params: '',
// eslint-disable-next-line no-shadow
success: function(val) {
state = decodeURI(val.toString());
store = {
@@ -159,6 +161,7 @@ var JSInput = (function($, undefined) {
// 200 ms and 5 times are arbitrary but this has functioned with the
// only application that has ever used JSInput, jsVGL. Something
// more sturdy should be put in place.
// eslint-disable-next-line no-inner-declarations
function whileloop(n) {
if (n > 0) {
try {