From b5acb55dcc009c3a2c89f2e34058ba2b32347f91 Mon Sep 17 00:00:00 2001 From: atesker Date: Mon, 10 Jun 2019 09:32:22 -0400 Subject: [PATCH 1/3] Potential fix for review rules - EDUCATOR-4262 --- cms/djangoapps/contentstore/views/item.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cms/djangoapps/contentstore/views/item.py b/cms/djangoapps/contentstore/views/item.py index 71d4cf44db..e4915cf17d 100644 --- a/cms/djangoapps/contentstore/views/item.py +++ b/cms/djangoapps/contentstore/views/item.py @@ -1230,6 +1230,11 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F proctoring_exam_configuration_link = get_exam_configuration_dashboard_url( course.id, xblock_info['id']) + if course.proctoring_provider == 'proctortrack': + show_review_rules = SHOW_REVIEW_RULES_FLAG.is_enabled(xblock.location.course_key) + else: + show_review_rules = True + xblock_info.update({ 'is_proctored_exam': xblock.is_proctored_exam, 'online_proctoring_rules': rules_url, @@ -1240,9 +1245,10 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F 'default_time_limit_minutes': xblock.default_time_limit_minutes, 'proctoring_exam_configuration_link': proctoring_exam_configuration_link, 'supports_onboarding': supports_onboarding, - 'show_review_rules': SHOW_REVIEW_RULES_FLAG.is_enabled(xblock.location.course_key), + 'show_review_rules': show_review_rules # SHOW_REVIEW_RULES_FLAG.is_enabled(xblock.location.course_key), }) + # Update with gating info xblock_info.update(_get_gating_info(course, xblock)) From 6ed1bb72ccd8d1dfff8d05dd0b5b86f91950cb6e Mon Sep 17 00:00:00 2001 From: atesker Date: Mon, 10 Jun 2019 09:54:11 -0400 Subject: [PATCH 2/3] Potential fix for review rules - EDUCATOR-4262 --- cms/djangoapps/contentstore/views/item.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cms/djangoapps/contentstore/views/item.py b/cms/djangoapps/contentstore/views/item.py index e4915cf17d..beae7cb875 100644 --- a/cms/djangoapps/contentstore/views/item.py +++ b/cms/djangoapps/contentstore/views/item.py @@ -1245,7 +1245,7 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F 'default_time_limit_minutes': xblock.default_time_limit_minutes, 'proctoring_exam_configuration_link': proctoring_exam_configuration_link, 'supports_onboarding': supports_onboarding, - 'show_review_rules': show_review_rules # SHOW_REVIEW_RULES_FLAG.is_enabled(xblock.location.course_key), + 'show_review_rules': show_review_rules }) From 817de2b215c2d0e3e917e2d74c37e4abb60124e0 Mon Sep 17 00:00:00 2001 From: atesker Date: Mon, 10 Jun 2019 10:56:13 -0400 Subject: [PATCH 3/3] Potential fix for review rules - EDUCATOR-4262 --- cms/djangoapps/contentstore/views/item.py | 1 - 1 file changed, 1 deletion(-) diff --git a/cms/djangoapps/contentstore/views/item.py b/cms/djangoapps/contentstore/views/item.py index beae7cb875..492a36d24d 100644 --- a/cms/djangoapps/contentstore/views/item.py +++ b/cms/djangoapps/contentstore/views/item.py @@ -1248,7 +1248,6 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F 'show_review_rules': show_review_rules }) - # Update with gating info xblock_info.update(_get_gating_info(course, xblock))