build: update stylint and eslint thresholds (#29471)

* build: update stylint and eslint thresholds

* Removed stylint threshold

* Update test_stylelint.py

* fix: fix eslint issues

scripts/delete-mongo-test-dbs.js

@@ -11,7 +11,7 @@ but ignore other databases.
 
 
 String.prototype.startsWith = function(substring) {
-    return (this.indexOf(substring) == 0);
+    return (this.indexOf(substring) === 0);
 };
 
 var dbNameList = db.getMongo().getDBNames();

scripts/generic-ci-tests.sh

@@ -131,7 +131,7 @@ case "$TEST_SUITE" in
                 echo "Finding ESLint violations and storing report..."
                 run_paver_quality run_eslint -l $ESLINT_THRESHOLD || { EXIT=1; }
                 echo "Finding Stylelint violations and storing report..."
-                run_paver_quality run_stylelint -l $STYLELINT_THRESHOLD || { EXIT=1; }
+                run_paver_quality run_stylelint || { EXIT=1; }
                 echo "Running xss linter report."
                 run_paver_quality run_xsslint -t $XSSLINT_THRESHOLDS || { EXIT=1; }
                 if [[ ! -z "$TARGET_BRANCH" ]]; then

scripts/thresholds.sh

@@ -1,5 +1,4 @@
 #!/usr/bin/env bash
 set -e
 
-export ESLINT_THRESHOLD=5300
-export STYLELINT_THRESHOLD=880
+export ESLINT_THRESHOLD=4950