diff --git a/common/lib/xmodule/xmodule/modulestore/tests/__init__.py b/common/lib/xmodule/xmodule/modulestore/tests/__init__.py index 2759f2540c..e69de29bb2 100644 --- a/common/lib/xmodule/xmodule/modulestore/tests/__init__.py +++ b/common/lib/xmodule/xmodule/modulestore/tests/__init__.py @@ -1,10 +0,0 @@ -from path import path - -# from ~/mitx_all/mitx/common/lib/xmodule/xmodule/modulestore/tests/ -# to ~/mitx_all/mitx/common/test -TEST_DIR = path(__file__).abspath().dirname() -for i in range(5): - TEST_DIR = TEST_DIR.dirname() -TEST_DIR = TEST_DIR / 'test' - -DATA_DIR = TEST_DIR / 'data' diff --git a/common/lib/xmodule/xmodule/modulestore/tests/test_mongo.py b/common/lib/xmodule/xmodule/modulestore/tests/test_mongo.py index c149724cc7..69ba9ad94b 100644 --- a/common/lib/xmodule/xmodule/modulestore/tests/test_mongo.py +++ b/common/lib/xmodule/xmodule/modulestore/tests/test_mongo.py @@ -1,18 +1,18 @@ -import pymongo +from pprint import pprint from nose.tools import assert_equals, assert_raises, assert_not_equals, assert_false -from pprint import pprint +import pymongo +from uuid import uuid4 from xblock.core import Scope from xblock.runtime import KeyValueStore, InvalidScopeError +from xmodule.tests import DATA_DIR from xmodule.modulestore import Location from xmodule.modulestore.mongo import MongoModuleStore, MongoKeyValueStore from xmodule.modulestore.xml_importer import import_from_xml -from .test_modulestore import check_path_to_location -from . import DATA_DIR -from uuid import uuid4 +from xmodule.modulestore.tests.test_modulestore import check_path_to_location HOST = 'localhost' diff --git a/common/lib/xmodule/xmodule/modulestore/tests/test_xml.py b/common/lib/xmodule/xmodule/modulestore/tests/test_xml.py index c3b7ea58bc..1819850614 100644 --- a/common/lib/xmodule/xmodule/modulestore/tests/test_xml.py +++ b/common/lib/xmodule/xmodule/modulestore/tests/test_xml.py @@ -1,12 +1,12 @@ import os.path +from nose.tools import assert_raises + from xmodule.course_module import CourseDescriptor from xmodule.modulestore.xml import XMLModuleStore -from nose.tools import assert_raises - -from .test_modulestore import check_path_to_location -from . import DATA_DIR +from xmodule.tests import DATA_DIR +from xmodule.modulestore.tests.test_modulestore import check_path_to_location class TestXMLModuleStore(object): diff --git a/common/lib/xmodule/xmodule/tests/__init__.py b/common/lib/xmodule/xmodule/tests/__init__.py index 1c08f837f8..df197edb87 100644 --- a/common/lib/xmodule/xmodule/tests/__init__.py +++ b/common/lib/xmodule/xmodule/tests/__init__.py @@ -7,19 +7,24 @@ Run like this: """ -import unittest +import json import os +import unittest + import fs import fs.osfs - import numpy - -import json +from mock import Mock +from path import path import calc -import xmodule -from xmodule.x_module import ModuleSystem -from mock import Mock +from xmodule.x_module import ModuleSystem, XModuleDescriptor + + +# Location of common test DATA directory +# '../../../../edx-platform/common/test/data/' +MODULE_DIR = path(__file__).dirname() +DATA_DIR = path.joinpath(*MODULE_DIR.splitall()[:-4]) / 'test/data/' open_ended_grading_interface = { @@ -67,7 +72,7 @@ class ModelsTest(unittest.TestCase): pass def test_load_class(self): - vc = xmodule.x_module.XModuleDescriptor.load_class('video') + vc = XModuleDescriptor.load_class('video') vc_str = "" self.assertEqual(str(vc), vc_str) diff --git a/common/lib/xmodule/xmodule/tests/test_combined_open_ended.py b/common/lib/xmodule/xmodule/tests/test_combined_open_ended.py index 4fd0ddccf7..8f703239a9 100644 --- a/common/lib/xmodule/xmodule/tests/test_combined_open_ended.py +++ b/common/lib/xmodule/xmodule/tests/test_combined_open_ended.py @@ -1,31 +1,3 @@ -import json -from mock import Mock, MagicMock, ANY -import unittest - -from test_util_open_ended import MockQueryDict, DummyModulestore - -from xmodule.open_ended_grading_classes.openendedchild import OpenEndedChild -from xmodule.open_ended_grading_classes.open_ended_module import OpenEndedModule -from xmodule.open_ended_grading_classes.combined_open_ended_modulev1 import CombinedOpenEndedV1Module -from xmodule.open_ended_grading_classes.grading_service_module import GradingServiceError -from xmodule.combined_open_ended_module import CombinedOpenEndedModule -from xmodule.modulestore import Location - -from lxml import etree -import capa.xqueue_interface as xqueue_interface -from datetime import datetime -from pytz import UTC -import logging - -log = logging.getLogger(__name__) - -from . import get_test_system - -ORG = 'edX' -COURSE = 'open_ended' # name of directory with course data - -import test_util_open_ended - """ Tests for the various pieces of the CombinedOpenEndedGrading system @@ -34,6 +6,31 @@ OpenEndedModule """ +from datetime import datetime +import json +import logging +import unittest + +from lxml import etree +from mock import Mock, MagicMock, ANY +from pytz import UTC + +from xmodule.open_ended_grading_classes.openendedchild import OpenEndedChild +from xmodule.open_ended_grading_classes.open_ended_module import OpenEndedModule +from xmodule.open_ended_grading_classes.combined_open_ended_modulev1 import CombinedOpenEndedV1Module +from xmodule.open_ended_grading_classes.grading_service_module import GradingServiceError +from xmodule.combined_open_ended_module import CombinedOpenEndedModule +from xmodule.modulestore import Location +from xmodule.tests import get_test_system, test_util_open_ended +from xmodule.tests.test_util_open_ended import MockQueryDict, DummyModulestore +import capa.xqueue_interface as xqueue_interface + + +log = logging.getLogger(__name__) + +ORG = 'edX' +COURSE = 'open_ended' # name of directory with course data + class OpenEndedChildTest(unittest.TestCase): """ diff --git a/common/lib/xmodule/xmodule/tests/test_conditional.py b/common/lib/xmodule/xmodule/tests/test_conditional.py index b28d236369..95472a62ed 100644 --- a/common/lib/xmodule/xmodule/tests/test_conditional.py +++ b/common/lib/xmodule/xmodule/tests/test_conditional.py @@ -1,22 +1,21 @@ +from ast import literal_eval import json import unittest + from fs.memoryfs import MemoryFS -from ast import literal_eval from mock import Mock, patch from xmodule.error_module import NonStaffErrorDescriptor from xmodule.modulestore import Location from xmodule.modulestore.xml import ImportSystem, XMLModuleStore from xmodule.conditional_module import ConditionalModule +from xmodule.tests import DATA_DIR, get_test_system -from xmodule.tests.test_export import DATA_DIR ORG = 'test_org' COURSE = 'conditional' # name of directory with course data -from . import get_test_system - class DummySystem(ImportSystem): diff --git a/common/lib/xmodule/xmodule/tests/test_export.py b/common/lib/xmodule/xmodule/tests/test_export.py index 91ef1bae57..d9b80422e9 100644 --- a/common/lib/xmodule/xmodule/tests/test_export.py +++ b/common/lib/xmodule/xmodule/tests/test_export.py @@ -2,28 +2,19 @@ Tests of XML export """ -import unittest -import pytz - from datetime import datetime, timedelta, tzinfo -from fs.osfs import OSFS -from path import path from tempfile import mkdtemp +import unittest import shutil -from xmodule.modulestore.xml import XMLModuleStore -from xmodule.modulestore.xml_exporter import EdxJSONEncoder +import pytz +from fs.osfs import OSFS +from path import path from xmodule.modulestore import Location - -# from ~/mitx_all/mitx/common/lib/xmodule/xmodule/tests/ -# to ~/mitx_all/mitx/common/test -TEST_DIR = path(__file__).abspath().dirname() -for i in range(4): - TEST_DIR = TEST_DIR.dirname() -TEST_DIR = TEST_DIR / 'test' - -DATA_DIR = TEST_DIR / 'data' +from xmodule.modulestore.xml import XMLModuleStore +from xmodule.modulestore.xml_exporter import EdxJSONEncoder +from xmodule.tests import DATA_DIR def strip_filenames(descriptor): diff --git a/common/lib/xmodule/xmodule/tests/test_import.py b/common/lib/xmodule/xmodule/tests/test_import.py index fb1bed2d3a..b6758dc917 100644 --- a/common/lib/xmodule/xmodule/tests/test_import.py +++ b/common/lib/xmodule/xmodule/tests/test_import.py @@ -1,20 +1,21 @@ # -*- coding: utf-8 -*- +import datetime import unittest -from fs.memoryfs import MemoryFS +from fs.memoryfs import MemoryFS from lxml import etree from mock import Mock, patch +from django.utils.timezone import UTC + from xmodule.xml_module import is_pointer_tag from xmodule.modulestore import Location from xmodule.modulestore.xml import ImportSystem, XMLModuleStore from xmodule.modulestore.inheritance import compute_inherited_metadata from xmodule.fields import Date +from xmodule.tests import DATA_DIR -from .test_export import DATA_DIR -import datetime -from django.utils.timezone import UTC ORG = 'test_org' COURSE = 'test_course' diff --git a/common/lib/xmodule/xmodule/tests/test_util_open_ended.py b/common/lib/xmodule/xmodule/tests/test_util_open_ended.py index 63fb4631c9..c717d52d31 100644 --- a/common/lib/xmodule/xmodule/tests/test_util_open_ended.py +++ b/common/lib/xmodule/xmodule/tests/test_util_open_ended.py @@ -1,7 +1,6 @@ -from .import get_test_system from xmodule.modulestore import Location from xmodule.modulestore.xml import XMLModuleStore -from xmodule.tests.test_export import DATA_DIR +from xmodule.tests import DATA_DIR, get_test_system OPEN_ENDED_GRADING_INTERFACE = { 'url': 'blah/', @@ -42,7 +41,7 @@ class DummyModulestore(object): def setup_modulestore(self, name): self.modulestore = XMLModuleStore(DATA_DIR, course_dirs=[name]) - def get_course(self, name): + def get_course(self, _): """Get a test course by directory name. If there's more than one, error.""" courses = self.modulestore.get_courses() return courses[0]