From 828c53cb64323cc1e9da51925ea9b13bea99cd5c Mon Sep 17 00:00:00 2001 From: Matt Drayer Date: Mon, 6 Nov 2017 10:13:47 -0500 Subject: [PATCH] SuccessFactors OData: Support null exception object scenarios --- common/djangoapps/third_party_auth/saml.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/djangoapps/third_party_auth/saml.py b/common/djangoapps/third_party_auth/saml.py index f0fa2ee7f8..eb5046620c 100644 --- a/common/djangoapps/third_party_auth/saml.py +++ b/common/djangoapps/third_party_auth/saml.py @@ -308,6 +308,7 @@ class SapSuccessFactorsIdentityProvider(EdXSAMLIdentityProvider): except requests.RequestException as err: # If there was an HTTP level error, log the error and return the details from the SAML assertion. sys_msg = err.response.json() if err.response else "Not available" + headers = err.response.headers if err.response else "Not available" log_msg_template = ( 'Unable to retrieve user details with username {username} from SAPSuccessFactors for company ' + 'ID {company} with url "{url}". Error message: {err_msg}. System message: {sys_msg}. ' + @@ -319,7 +320,7 @@ class SapSuccessFactorsIdentityProvider(EdXSAMLIdentityProvider): url=odata_api_url, err_msg=err.message, sys_msg=sys_msg, - headers=err.response.headers + headers=headers ) log.warning(log_msg, exc_info=True) return details