From 80cb98affd317ce0809b3f35e545604b976715ce Mon Sep 17 00:00:00 2001 From: Tyler Hallada Date: Wed, 14 Mar 2018 12:51:01 -0400 Subject: [PATCH] Use try-except-else instead of continue --- .../core/djangoapps/schedules/resolvers.py | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/openedx/core/djangoapps/schedules/resolvers.py b/openedx/core/djangoapps/schedules/resolvers.py index 72be5f5663..2e9e91cf7c 100644 --- a/openedx/core/djangoapps/schedules/resolvers.py +++ b/openedx/core/djangoapps/schedules/resolvers.py @@ -357,21 +357,21 @@ class CourseUpdateResolver(BinnedSchedulesBaseResolver): user, week_num, enrollment.course_id ) ) - continue + # continue to the next schedule, don't yield an email for this one + else: + template_context.update({ + 'course_name': schedule.enrollment.course.display_name, + 'course_url': _get_trackable_course_home_url(enrollment.course_id), - template_context.update({ - 'course_name': schedule.enrollment.course.display_name, - 'course_url': _get_trackable_course_home_url(enrollment.course_id), + 'week_num': week_num, + 'week_highlights': week_highlights, - 'week_num': week_num, - 'week_highlights': week_highlights, + # This is used by the bulk email optout policy + 'course_ids': [str(enrollment.course_id)], + }) + template_context.update(_get_upsell_information_for_schedule(user, schedule)) - # This is used by the bulk email optout policy - 'course_ids': [str(enrollment.course_id)], - }) - template_context.update(_get_upsell_information_for_schedule(user, schedule)) - - yield (user, schedule.enrollment.course.closest_released_language, template_context) + yield (user, schedule.enrollment.course.closest_released_language, template_context) def _get_trackable_course_home_url(course_id):