From cc5a5e2996cb02ab669c4c5205565a0a20058e53 Mon Sep 17 00:00:00 2001
From: cahrens <christina@edx.org>
Date: Wed, 16 Jan 2013 12:52:05 -0500
Subject: [PATCH 1/2] Fix multiple choice checkbox. #117

---
 .../lib/xmodule/xmodule/js/spec/problem/edit_spec.coffee  | 8 ++++----
 common/lib/xmodule/xmodule/js/src/problem/edit.coffee     | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/common/lib/xmodule/xmodule/js/spec/problem/edit_spec.coffee b/common/lib/xmodule/xmodule/js/spec/problem/edit_spec.coffee
index 5217385d80..9b8062d60d 100644
--- a/common/lib/xmodule/xmodule/js/spec/problem/edit_spec.coffee
+++ b/common/lib/xmodule/xmodule/js/spec/problem/edit_spec.coffee
@@ -316,15 +316,15 @@ describe 'MarkdownEditingDescriptor', ->
         </multiplechoiceresponse>
         
         <p>Choice checks</p>
-        <multiplechoiceresponse>
-          <choicegroup type="MultipleChoiceChecks">
+        <choiceresponse>
+          <checkboxgroup direction="vertical">
             <choice correct="false">option1 [x]</choice>
             <choice correct="true">correct</choice>
             <choice correct="true">redundant</choice>
             <choice correct="false">distractor</choice>
             <choice correct="false">no space</choice>
-          </choicegroup>
-        </multiplechoiceresponse>
+          </checkboxgroup>
+        </choiceresponse>
         
         <p>Option with multiple correct ones</p>
         
diff --git a/common/lib/xmodule/xmodule/js/src/problem/edit.coffee b/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
index 8e5f18ef05..2bfe483a7f 100644
--- a/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
+++ b/common/lib/xmodule/xmodule/js/src/problem/edit.coffee
@@ -213,8 +213,8 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor
 
       // group check answers
       xml = xml.replace(/(^\s*\[.?\].*?$\n*)+/gm, function(match, p) {
-        var groupString = '<multiplechoiceresponse>\n';
-        groupString += '  <choicegroup type="MultipleChoiceChecks">\n';
+        var groupString = '<choiceresponse>\n';
+        groupString += '  <checkboxgroup direction="vertical">\n';
         var options = match.split('\n');
         for(var i = 0; i < options.length; i++) {
           if(options[i].length > 0) {
@@ -223,8 +223,8 @@ class @MarkdownEditingDescriptor extends XModule.Descriptor
             groupString += '    <choice correct="' + correct + '">' + value + '</choice>\n';
           }
         }
-        groupString += '  </choicegroup>\n';
-        groupString += '</multiplechoiceresponse>\n\n';
+        groupString += '  </checkboxgroup>\n';
+        groupString += '</choiceresponse>\n\n';
         return groupString;
       });
 

From d4f79c0498775aa2540cc557d205bfc590be55e9 Mon Sep 17 00:00:00 2001
From: cahrens <christina@edx.org>
Date: Wed, 16 Jan 2013 13:51:17 -0500
Subject: [PATCH 2/2] Fix bug related to img link for non-img files.
 https://edx.lighthouseapp.com/projects/102637-studio/tickets/135-via-tender-studio-asset-locker-currently-returns-incorrect-xml-snippet

---
 cms/static/js/base.js          | 2 +-
 cms/templates/asset_index.html | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/cms/static/js/base.js b/cms/static/js/base.js
index 4137690395..e99fc9a4da 100644
--- a/cms/static/js/base.js
+++ b/cms/static/js/base.js
@@ -498,7 +498,7 @@ function displayFinishedUpload(xhr) {
     }
 
     var resp = JSON.parse(xhr.responseText);
-    $('.upload-modal .embeddable-xml-input').val('<img src="' + xhr.getResponseHeader('asset_url') + '"/>');
+    $('.upload-modal .embeddable-xml-input').val(xhr.getResponseHeader('asset_url'));
     $('.upload-modal .embeddable').show();
     $('.upload-modal .file-name').hide();
     $('.upload-modal .progress-fill').html(resp.msg);
diff --git a/cms/templates/asset_index.html b/cms/templates/asset_index.html
index ca205157ab..01766e2dac 100644
--- a/cms/templates/asset_index.html
+++ b/cms/templates/asset_index.html
@@ -28,7 +28,7 @@
         {{uploadDate}}
       </td>
       <td class="embed-col">
-        <input type="text" class="embeddable-xml-input" value='{{url}}'>
+        <input type="text" class="embeddable-xml-input" value='{{url}}' disabled>
       </td>
     </tr>
   </script>
@@ -69,7 +69,7 @@
                 ${asset['uploadDate']}
               </td>
               <td class="embed-col">
-                <input type="text" class="embeddable-xml-input" value='${asset['url']}'>
+                <input type="text" class="embeddable-xml-input" value="${asset['url']}" disabled>
               </td>
             </tr>
           % endfor
@@ -99,8 +99,8 @@
 				<div class="progress-fill"></div>
 			</div>
       <div class="embeddable">
-        <label>Embeddable XML:</label>
-        <input type="text" class="embeddable-xml-input" value='<img src=""/>'>
+        <label>URL:</label>
+        <input type="text" class="embeddable-xml-input" value='' disabled>
       </div>
 			<form class="file-chooser" action="${upload_asset_callback_url}"
                                 method="post" enctype="multipart/form-data">