diff --git a/common/djangoapps/util/sandboxing.py b/common/djangoapps/util/sandboxing.py index 8fcfa6dfbc..5fea7ed25c 100644 --- a/common/djangoapps/util/sandboxing.py +++ b/common/djangoapps/util/sandboxing.py @@ -25,7 +25,7 @@ def can_execute_unsafe_code(course_id): # To others using this: the code as-is is brittle and likely to be changed in the future, # as per the TODO, so please consider carefully before adding more values to COURSES_WITH_UNSAFE_CODE for regex in getattr(settings, 'COURSES_WITH_UNSAFE_CODE', []): - if re.match(regex, unicode(course_id)): + if re.match(regex, course_id.to_deprecated_string()): return True return False diff --git a/common/djangoapps/util/tests/test_sandboxing.py b/common/djangoapps/util/tests/test_sandboxing.py index 21179b1dfa..7a33fbbe95 100644 --- a/common/djangoapps/util/tests/test_sandboxing.py +++ b/common/djangoapps/util/tests/test_sandboxing.py @@ -3,7 +3,6 @@ Tests for sandboxing.py in util app """ from django.test import TestCase -from opaque_keys.edx.locator import LibraryLocator from util.sandboxing import can_execute_unsafe_code from django.test.utils import override_settings from opaque_keys.edx.locations import SlashSeparatedCourseKey @@ -13,13 +12,12 @@ class SandboxingTest(TestCase): """ Test sandbox whitelisting """ - @override_settings(COURSES_WITH_UNSAFE_CODE=['edX/full/.*', 'library:v1-edX+.*']) + @override_settings(COURSES_WITH_UNSAFE_CODE=['edX/full/.*']) def test_sandbox_exclusion(self): """ Test to make sure that a non-match returns false """ self.assertFalse(can_execute_unsafe_code(SlashSeparatedCourseKey('edX', 'notful', 'empty'))) - self.assertFalse(can_execute_unsafe_code(LibraryLocator('edY', 'test_bank'))) @override_settings(COURSES_WITH_UNSAFE_CODE=['edX/full/.*']) def test_sandbox_inclusion(self): @@ -28,12 +26,10 @@ class SandboxingTest(TestCase): """ self.assertTrue(can_execute_unsafe_code(SlashSeparatedCourseKey('edX', 'full', '2012_Fall'))) self.assertTrue(can_execute_unsafe_code(SlashSeparatedCourseKey('edX', 'full', '2013_Spring'))) - self.assertFalse(can_execute_unsafe_code(LibraryLocator('edX', 'test_bank'))) - def test_courselikes_with_unsafe_code_default(self): + def test_courses_with_unsafe_code_default(self): """ Test that the default setting for COURSES_WITH_UNSAFE_CODE is an empty setting, e.g. we don't use @override_settings in these tests """ self.assertFalse(can_execute_unsafe_code(SlashSeparatedCourseKey('edX', 'full', '2012_Fall'))) self.assertFalse(can_execute_unsafe_code(SlashSeparatedCourseKey('edX', 'full', '2013_Spring'))) - self.assertFalse(can_execute_unsafe_code(LibraryLocator('edX', 'test_bank')))