Merge pull request #16561 from edx/bmedx/django111_select_related
Remove use of non-relational fields in select_related queries
This commit is contained in:
@@ -182,7 +182,7 @@ def bulk_cache_cohorts(course_key, users):
|
||||
cohorts_by_user = {
|
||||
membership.user: membership
|
||||
for membership in
|
||||
CohortMembership.objects.filter(user__in=users, course_id=course_key).select_related('user__id')
|
||||
CohortMembership.objects.filter(user__in=users, course_id=course_key).select_related('user')
|
||||
}
|
||||
for user, membership in cohorts_by_user.iteritems():
|
||||
cache[_cohort_cache_key(user.id, course_key)] = membership.course_user_group
|
||||
|
||||
@@ -36,7 +36,7 @@ class BulkCourseTags(object):
|
||||
and the secondary key is the course tag's key
|
||||
"""
|
||||
course_tags = defaultdict(dict)
|
||||
for tag in UserCourseTag.objects.filter(user__in=users, course_id=course_id).select_related('user__id'):
|
||||
for tag in UserCourseTag.objects.filter(user__in=users, course_id=course_id).select_related('user'):
|
||||
course_tags[tag.user.id][tag.key] = tag.value
|
||||
get_cache(cls.CACHE_NAMESPACE)[cls._cache_key(course_id)] = course_tags
|
||||
|
||||
|
||||
Reference in New Issue
Block a user