From 7c74ecbb2323fae656b537838fb48a5f297bdbab Mon Sep 17 00:00:00 2001 From: Farhanah Sheets Date: Wed, 19 Dec 2018 09:49:47 -0500 Subject: [PATCH] Fix pep8/pylint violations --- .../tests/discussion/test_cohort_management.py | 2 +- .../acceptance/tests/discussion/test_discussion.py | 14 +++++++------- .../acceptance/tests/lms/test_account_settings.py | 2 +- common/test/acceptance/tests/lms/test_bookmarks.py | 2 +- .../acceptance/tests/lms/test_learner_profile.py | 8 ++++---- common/test/acceptance/tests/lms/test_lms.py | 8 ++++---- .../acceptance/tests/lms/test_lms_course_home.py | 4 ++-- .../acceptance/tests/lms/test_lms_dashboard.py | 2 +- .../tests/lms/test_lms_instructor_dashboard.py | 2 +- common/test/acceptance/tests/lms/test_programs.py | 6 +++--- .../acceptance/tests/lms/test_progress_page.py | 2 +- .../tests/studio/test_studio_textbooks.py | 2 +- 12 files changed, 27 insertions(+), 27 deletions(-) diff --git a/common/test/acceptance/tests/discussion/test_cohort_management.py b/common/test/acceptance/tests/discussion/test_cohort_management.py index 0cfd5fe6f0..22553280bb 100644 --- a/common/test/acceptance/tests/discussion/test_cohort_management.py +++ b/common/test/acceptance/tests/discussion/test_cohort_management.py @@ -692,7 +692,7 @@ class CohortConfigurationTest(EventsTestMixin, UniqueCourseTest, CohortTestMixin """ self.cohort_management_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.cohort_management_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/discussion/test_discussion.py b/common/test/acceptance/tests/discussion/test_discussion.py index a1a697970a..fae8bd228b 100644 --- a/common/test/acceptance/tests/discussion/test_discussion.py +++ b/common/test/acceptance/tests/discussion/test_discussion.py @@ -227,7 +227,7 @@ class DiscussionHomePageTest(BaseDiscussionTestCase): "ignore": [ 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.page.a11y_audit.check_for_accessibility_errors() @@ -465,7 +465,7 @@ class DiscussionTabMultipleThreadTest(BaseDiscussionTestCase, BaseDiscussionMixi "ignore": [ 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) @@ -538,7 +538,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase): 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) page.a11y_audit.check_for_accessibility_errors() @@ -549,7 +549,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase): 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) page.a11y_audit.check_for_accessibility_errors() @@ -843,7 +843,7 @@ class DiscussionResponseEditTest(BaseDiscussionTestCase): 'ignore': [ 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) page.visit() @@ -945,7 +945,7 @@ class DiscussionCommentEditTest(BaseDiscussionTestCase): 'ignore': [ 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) page.a11y_audit.check_for_accessibility_errors() @@ -1372,7 +1372,7 @@ class DiscussionSearchAlertTest(UniqueCourseTest): 'ignore': [ 'section', # TODO: AC-491 'aria-required-children', # TODO: AC-534 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/lms/test_account_settings.py b/common/test/acceptance/tests/lms/test_account_settings.py index e9a2eb7bac..6982667b58 100644 --- a/common/test/acceptance/tests/lms/test_account_settings.py +++ b/common/test/acceptance/tests/lms/test_account_settings.py @@ -567,7 +567,7 @@ class AccountSettingsA11yTest(AccountSettingsTestMixin, AcceptanceTest): self.visit_account_settings_page() self.account_settings_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.account_settings_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/lms/test_bookmarks.py b/common/test/acceptance/tests/lms/test_bookmarks.py index 6a66852308..7332913a05 100644 --- a/common/test/acceptance/tests/lms/test_bookmarks.py +++ b/common/test/acceptance/tests/lms/test_bookmarks.py @@ -597,7 +597,7 @@ class BookmarksA11yTests(BookmarksTestMixin): """ self.bookmarks_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.setup_test(num_chapters=11) diff --git a/common/test/acceptance/tests/lms/test_learner_profile.py b/common/test/acceptance/tests/lms/test_learner_profile.py index 35174159ba..4fc301c264 100644 --- a/common/test/acceptance/tests/lms/test_learner_profile.py +++ b/common/test/acceptance/tests/lms/test_learner_profile.py @@ -695,7 +695,7 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest): profile_page = self.visit_profile_page(username) profile_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) profile_page.a11y_audit.check_for_accessibility_errors() @@ -721,7 +721,7 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest): profile_page = self.visit_profile_page(different_username) profile_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) profile_page.a11y_audit.check_for_accessibility_errors() @@ -731,12 +731,12 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, AcceptanceTest): Test the accessibility of the badge listings and sharing modal. """ username = 'testcert' - + AutoAuthPage(self.browser, username=username).visit() profile_page = self.visit_profile_page(username) profile_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) profile_page.display_accomplishments() diff --git a/common/test/acceptance/tests/lms/test_lms.py b/common/test/acceptance/tests/lms/test_lms.py index 708e43d356..9dc11a5534 100644 --- a/common/test/acceptance/tests/lms/test_lms.py +++ b/common/test/acceptance/tests/lms/test_lms.py @@ -527,7 +527,7 @@ class CourseWikiA11yTest(UniqueCourseTest): """ self.course_wiki_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.course_wiki_page.a11y_audit.check_for_accessibility_errors() @@ -539,7 +539,7 @@ class CourseWikiA11yTest(UniqueCourseTest): self._open_editor() self.course_wiki_edit_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.course_wiki_edit_page.a11y_audit.check_for_accessibility_errors() @@ -552,7 +552,7 @@ class CourseWikiA11yTest(UniqueCourseTest): history_page = CourseWikiHistoryPage(self.browser, self.course_id, self.course_info) history_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) history_page.wait_for_page() @@ -566,7 +566,7 @@ class CourseWikiA11yTest(UniqueCourseTest): children_page = CourseWikiChildrenPage(self.browser, self.course_id, self.course_info) children_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) children_page.wait_for_page() diff --git a/common/test/acceptance/tests/lms/test_lms_course_home.py b/common/test/acceptance/tests/lms/test_lms_course_home.py index 93adec9d14..b8c6858b29 100644 --- a/common/test/acceptance/tests/lms/test_lms_course_home.py +++ b/common/test/acceptance/tests/lms/test_lms_course_home.py @@ -138,7 +138,7 @@ class CourseHomeA11yTest(CourseHomeBaseTest): course_home_page.visit() course_home_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) course_home_page.a11y_audit.check_for_accessibility_errors() @@ -152,7 +152,7 @@ class CourseHomeA11yTest(CourseHomeBaseTest): course_search_results_page = course_home_page.search_for_term("Test Search") course_search_results_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) course_search_results_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/lms/test_lms_dashboard.py b/common/test/acceptance/tests/lms/test_lms_dashboard.py index 0fc417a2f6..fe8dc54651 100644 --- a/common/test/acceptance/tests/lms/test_lms_dashboard.py +++ b/common/test/acceptance/tests/lms/test_lms_dashboard.py @@ -411,7 +411,7 @@ class LmsDashboardA11yTest(BaseLmsDashboardTestMultiple): """ self.dashboard_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) course_listings = self.dashboard_page.get_courses() diff --git a/common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py b/common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py index eb565fb3eb..5f1d50c96a 100644 --- a/common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py +++ b/common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py @@ -79,7 +79,7 @@ class LMSInstructorDashboardA11yTest(BaseInstructorDashboardTest): def test_instructor_dashboard_a11y(self): self.instructor_dashboard_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.instructor_dashboard_page.a11y_audit.check_for_accessibility_errors() diff --git a/common/test/acceptance/tests/lms/test_programs.py b/common/test/acceptance/tests/lms/test_programs.py index 86b0417ff1..34e9889362 100644 --- a/common/test/acceptance/tests/lms/test_programs.py +++ b/common/test/acceptance/tests/lms/test_programs.py @@ -123,7 +123,7 @@ class ProgramListingPageA11yTest(ProgramPageBase): """Test a11y of the page's empty state.""" self.listing_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.auth(enroll=False) @@ -140,7 +140,7 @@ class ProgramListingPageA11yTest(ProgramPageBase): """Test a11y when program cards are present.""" self.listing_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.auth() @@ -169,7 +169,7 @@ class ProgramDetailsPageA11yTest(ProgramPageBase): """Test the page's a11y compliance.""" self.details_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.auth() diff --git a/common/test/acceptance/tests/lms/test_progress_page.py b/common/test/acceptance/tests/lms/test_progress_page.py index f36bff06cf..2292385161 100644 --- a/common/test/acceptance/tests/lms/test_progress_page.py +++ b/common/test/acceptance/tests/lms/test_progress_page.py @@ -431,7 +431,7 @@ class ProgressPageA11yTest(ProgressPageBaseTest): """ self.progress_page.a11y_audit.config.set_rules({ "ignore": [ - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ] }) self.progress_page.visit() diff --git a/common/test/acceptance/tests/studio/test_studio_textbooks.py b/common/test/acceptance/tests/studio/test_studio_textbooks.py index 5516ea80fd..56f9b9a88a 100644 --- a/common/test/acceptance/tests/studio/test_studio_textbooks.py +++ b/common/test/acceptance/tests/studio/test_studio_textbooks.py @@ -80,7 +80,7 @@ class TextbooksTest(StudioCourseTest): self.textbook_view_page.a11y_audit.config.set_rules({ 'ignore': [ 'section', # AC-503 - 'aria-valid-attr', #TODO: LEARNER-6611 & LEARNER-6865 + 'aria-valid-attr', # TODO: LEARNER-6611 & LEARNER-6865 ], }) self.textbook_view_page.a11y_audit.check_for_accessibility_errors()