From 7b71271bc1e06eaada644c7a156e1184737e0f11 Mon Sep 17 00:00:00 2001 From: Steve Strassmann Date: Mon, 13 May 2013 15:21:29 -0400 Subject: [PATCH] prefix unused vars with _ --- cms/djangoapps/contentstore/views/assets.py | 14 ++++++-------- cms/djangoapps/contentstore/views/preview.py | 4 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/cms/djangoapps/contentstore/views/assets.py b/cms/djangoapps/contentstore/views/assets.py index 1e818f607a..b5041d3e9f 100644 --- a/cms/djangoapps/contentstore/views/assets.py +++ b/cms/djangoapps/contentstore/views/assets.py @@ -176,7 +176,7 @@ def import_course(request, org, course, name): # find the 'course.xml' file - for dirpath, dirnames, filenames in os.walk(course_dir): + for dirpath, _dirnames, filenames in os.walk(course_dir): for files in filenames: if files == 'course.xml': break @@ -192,13 +192,11 @@ def import_course(request, org, course, name): for fname in os.listdir(dirpath): shutil.move(dirpath / fname, course_dir) - # var module_store is unused - # pylint: disable=W0612 - module_store, course_items = import_from_xml(modulestore('direct'), settings.GITHUB_REPO_ROOT, - [course_subdir], load_error_modules=False, - static_content_store=contentstore(), - target_location_namespace=Location(location), - draft_store=modulestore()) + _module_store, course_items = import_from_xml(modulestore('direct'), settings.GITHUB_REPO_ROOT, + [course_subdir], load_error_modules=False, + static_content_store=contentstore(), + target_location_namespace=Location(location), + draft_store=modulestore()) # we can blow this away when we're done importing. shutil.rmtree(course_dir) diff --git a/cms/djangoapps/contentstore/views/preview.py b/cms/djangoapps/contentstore/views/preview.py index 515ea3e837..deef6a27c9 100644 --- a/cms/djangoapps/contentstore/views/preview.py +++ b/cms/djangoapps/contentstore/views/preview.py @@ -96,7 +96,7 @@ def preview_module_system(request, preview_id, descriptor): return ModuleSystem( ajax_url=reverse('preview_dispatch', args=[preview_id, descriptor.location.url(), '']).rstrip('/'), # TODO (cpennington): Do we want to track how instructors are using the preview problems? - track_function=lambda type, event: None, + track_function=lambda event_type, event: None, filestore=descriptor.system.resources_fs, get_module=partial(get_preview_module, request, preview_id), render_template=render_from_lms, @@ -171,7 +171,7 @@ def get_module_previews(request, descriptor): descriptor: An XModuleDescriptor """ preview_html = [] - for idx, (instance_state, shared_state) in enumerate(descriptor.get_sample_state()): + for idx, (_instance_state, _shared_state) in enumerate(descriptor.get_sample_state()): module = load_preview_module(request, str(idx), descriptor) preview_html.append(module.get_html()) return preview_html