From e265a754aa65b81dd848a4f23a73c39165626e51 Mon Sep 17 00:00:00 2001 From: Robert Raposa Date: Tue, 27 Oct 2020 15:37:10 -0400 Subject: [PATCH] fix update assets An xmodule file that is loaded during update_assets without settings was referring to the FEATURES setting without checking if it existed. --- common/lib/xmodule/xmodule/course_module.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/lib/xmodule/xmodule/course_module.py b/common/lib/xmodule/xmodule/course_module.py index 655a3b67e2..73a48e3277 100644 --- a/common/lib/xmodule/xmodule/course_module.py +++ b/common/lib/xmodule/xmodule/course_module.py @@ -49,7 +49,8 @@ DEFAULT_COURSE_VISIBILITY_IN_CATALOG = getattr( ) DEFAULT_MOBILE_AVAILABLE = getattr(settings, 'DEFAULT_MOBILE_AVAILABLE', False) -EXAM_SETTINGS_HTML_VIEW_ENABLED = settings.FEATURES.get('ENABLE_EXAM_SETTINGS_HTML_VIEW', False) +# Note: updating assets does not have settings defined, so using `getattr`. +EXAM_SETTINGS_HTML_VIEW_ENABLED = getattr(settings, 'FEATURES', {}).get('ENABLE_EXAM_SETTINGS_HTML_VIEW', False) COURSE_VISIBILITY_PRIVATE = 'private' COURSE_VISIBILITY_PUBLIC_OUTLINE = 'public_outline'