From 7ade1cc1ab76bb3e3d653e1c2fe14b6e81fb0f37 Mon Sep 17 00:00:00 2001 From: Dillon Dumesnil Date: Mon, 14 Mar 2022 15:01:58 -0400 Subject: [PATCH] fix: Check discussion_link exists as an attr before accessing This is a patch to fix CR-4621. A longer term solution should be implemented. --- lms/djangoapps/courseware/tabs.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lms/djangoapps/courseware/tabs.py b/lms/djangoapps/courseware/tabs.py index 54190fa833..c6740f94b4 100644 --- a/lms/djangoapps/courseware/tabs.py +++ b/lms/djangoapps/courseware/tabs.py @@ -277,7 +277,9 @@ class ExternalDiscussionCourseTab(LinkTab): def is_enabled(cls, course, user=None): if not super().is_enabled(course, user=user): return False - return course.discussion_link + # Course Overview objects don't have this attribute so avoid the error for now and figure + # out a better long-term solution + return hasattr(course, 'discussion_link') and course.discussion_link class ExternalLinkCourseTab(LinkTab):