From 7917048fe37f81ae7964d6a9af7ca13d3d96f047 Mon Sep 17 00:00:00 2001 From: Attiya Ishaque Date: Tue, 7 Dec 2021 12:15:50 +0500 Subject: [PATCH] fix: add error-code in save for later rate limit api (#29483) --- lms/djangoapps/save_for_later/api/v1/views.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lms/djangoapps/save_for_later/api/v1/views.py b/lms/djangoapps/save_for_later/api/v1/views.py index 129d07600f..eb60ff0579 100644 --- a/lms/djangoapps/save_for_later/api/v1/views.py +++ b/lms/djangoapps/save_for_later/api/v1/views.py @@ -68,10 +68,10 @@ class SaveForLaterApiView(APIView): course_key = CourseKey.from_string(course_id) if getattr(request, 'limited', False): - return Response({'result': 'failure'}, status=403) + return Response({'error_code': 'rate-limited'}, status=403) if get_email_validation_error(email): - return Response({'result': 'failure'}, status=400) + return Response({'error_code': 'incorrect-email'}, status=400) try: course_overview = CourseOverview.get_from_id(course_key) @@ -81,7 +81,7 @@ class SaveForLaterApiView(APIView): course_id=course_id, ) except CourseOverview.DoesNotExist: - return Response({'result': 'failure'}, status=404) + return Response({'error-code': 'course-not-found'}, status=404) site = Site.objects.get_current() message_context = get_base_template_context(site) @@ -115,6 +115,6 @@ class SaveForLaterApiView(APIView): ) except Exception: # pylint: disable=broad-except log.warning('Unable to send save for later email ', exc_info=True) - return Response({'result': 'failure'}, status=400) + return Response({'error-code': 'email-not-send'}, status=400) else: return Response({'result': 'success'}, status=200)