Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARCHBOM-1305: remove deprecated flag_undefined_default (#24426)

Browse Source 
This is the final step in removing the deprecated
flag_undefined_default as explained by the following ADR:
https://github.com/edx/edx-platform/blob/master/openedx/core/djangoapps/waffle_utils/docs/decisions/0001-refactor-waffle-flag-default.rst

Notes:

* All uses of flag_undefined_default=False were always
  supposed to have been no-ops.
* All uses of flag_undefined_default=True that are removed
  in this PR have been replaced by migrations in past PRs.
* The temporary metric temp_flag_default_used id no longer
  reporting any data.

ARCHBOM-1305
This commit is contained in:
Robert Raposa
2020-07-09 09:31:31 -04:00
committed by GitHub
parent 36e07f6be8
commit 77e490f057
19 changed files with 89 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
openedx/features/course_experience/__init__.py
View File

@@ -22,7 +22,7 @@ class DefaultTrueWaffleFlagNamespace(WaffleFlagNamespace):
and refactor/fix any tests that shouldn't be removed.
"""
def is_flag_active(self, flag_name, check_before_waffle_callback=None, flag_undefined_default=None):
def is_flag_active(self, flag_name, check_before_waffle_callback=None):
"""
Overrides is_flag_active, and returns and caches whether the provided flag is active.

1
openedx/features/discounts/applicability.py
View File

@@ -40,7 +40,6 @@ from track import segment
DISCOUNT_APPLICABILITY_FLAG = WaffleFlag(
waffle_namespace=WaffleFlagNamespace(name=u'discounts'),
flag_name=u'enable_discounting',
flag_undefined_default=False
)
DISCOUNT_APPLICABILITY_HOLDBACK = 'first_purchase_discount_holdback'