From 755aad04f7b15b94ce9f7cde1f180242d485cd3a Mon Sep 17 00:00:00 2001 From: rabiaiftikhar Date: Tue, 30 May 2017 15:52:11 +0500 Subject: [PATCH] modify doc strings. --- .../tests/lms/test_certificate_web_view.py | 2 ++ lms/djangoapps/certificates/signals.py | 12 +++++++----- lms/djangoapps/certificates/tests/test_signals.py | 9 +++++---- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/common/test/acceptance/tests/lms/test_certificate_web_view.py b/common/test/acceptance/tests/lms/test_certificate_web_view.py index 5e47c441ed..2998385dea 100644 --- a/common/test/acceptance/tests/lms/test_certificate_web_view.py +++ b/common/test/acceptance/tests/lms/test_certificate_web_view.py @@ -2,6 +2,7 @@ Acceptance tests for the certificate web view feature. """ from nose.plugins.attrib import attr + from common.test.acceptance.fixtures.certificates import CertificateConfigFixture from common.test.acceptance.fixtures.course import CourseFixture, CourseUpdateDesc, XBlockFixtureDesc from common.test.acceptance.pages.lms.auto_auth import AutoAuthPage @@ -22,6 +23,7 @@ from common.test.acceptance.tests.helpers import ( get_modal_alert, ) + @attr(shard=5) class CertificateWebViewTest(EventsTestMixin, UniqueCourseTest): """ diff --git a/lms/djangoapps/certificates/signals.py b/lms/djangoapps/certificates/signals.py index e5b87df239..6097dfad8b 100644 --- a/lms/djangoapps/certificates/signals.py +++ b/lms/djangoapps/certificates/signals.py @@ -1,25 +1,27 @@ -""" Signal handler for enabling self-generated certificates for self-paced -courses and disabling for instructor-paced courses. +""" +Signal handler for enabling/disabling self-generated certificates based on the course-pacing. """ from celery.task import task from django.dispatch.dispatcher import receiver from certificates.models import CertificateGenerationCourseSetting from opaque_keys.edx.keys import CourseKey -from xmodule.modulestore.django import SignalHandler, modulestore +from xmodule.modulestore.django import modulestore, SignalHandler @receiver(SignalHandler.course_published) def _listen_for_course_publish(sender, course_key, **kwargs): # pylint: disable=unused-argument """ Catches the signal that a course has been published in Studio and - enable/disable the self-generated certificates for courses according to pacing. + enable/disable the self-generated certificates according to course-pacing. """ set_self_generated_certs.delay(unicode(course_key)) @task() def set_self_generated_certs(course_key): - """Enable or disable self-generated certificates for a course according to pacing.""" + """ + Enable or disable self-generated certificates for a course according to pacing. + """ course_key = CourseKey.from_string(course_key) course = modulestore().get_course(course_key) CertificateGenerationCourseSetting.set_enabled_for_course(course_key, course.self_paced) diff --git a/lms/djangoapps/certificates/tests/test_signals.py b/lms/djangoapps/certificates/tests/test_signals.py index 99e05f75a6..6ddcb98e3d 100644 --- a/lms/djangoapps/certificates/tests/test_signals.py +++ b/lms/djangoapps/certificates/tests/test_signals.py @@ -1,5 +1,6 @@ -""" Unit tests for enabling self-generated certificates for -self-paced courses and disabling for instructor-paced courses. +""" +Unit tests for enabling self-generated certificates for self-paced courses +and disabling for instructor-paced courses. """ from certificates import api as certs_api from certificates.models import CertificateGenerationConfiguration @@ -10,8 +11,8 @@ from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase class SelfGeneratedCertsSignalTest(ModuleStoreTestCase): - """ Tests for enabling/disabling self-generated certificates - according to pacing. + """ + Tests for enabling/disabling self-generated certificates according to course-pacing. """ def setUp(self):