Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use node for running node.js tests, not nodejs (#25651)

Browse Source 
This should solve the problem of getting `nodejs: not found` when
running `paver test_js_run -s lms` in lms-shell, which cropped up in
the past few days.

I don't know why this stopped working recently, but I don't have `nodejs`
on my recently re-created devstack, and some people with an older devstack
have both. Maybe a recent node.js release got rid of an alias.
This commit is contained in:
Tim McCormack
2020-11-19 15:09:51 -05:00
committed by GitHub
parent 81705589a4
commit 747b03febf
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pavelib/paver_tests/test_js_test.py
View File

@@ -119,7 +119,7 @@ class TestPaverJavaScriptTestTasks(PaverTestCase):
expected_messages.append(self.EXPECTED_INSTALL_NPM_ASSETS_COMMAND) expected_messages.append(self.EXPECTED_INSTALL_NPM_ASSETS_COMMAND)
command_template = ( command_template = (
'nodejs --max_old_space_size=4096 node_modules/.bin/karma start {options}' 'node --max_old_space_size=4096 node_modules/.bin/karma start {options}'
) )
for suite in suites: for suite in suites:

2
pavelib/quality.py
View File

@@ -331,7 +331,7 @@ def run_eslint(options):
violations_limit = int(getattr(options, 'limit', -1)) violations_limit = int(getattr(options, 'limit', -1))
sh( sh(
"nodejs --max_old_space_size=4096 node_modules/.bin/eslint " "node --max_old_space_size=4096 node_modules/.bin/eslint "
"--ext .js --ext .jsx --format=compact . | tee {eslint_report}".format( "--ext .js --ext .jsx --format=compact . | tee {eslint_report}".format(
eslint_report=eslint_report eslint_report=eslint_report
), ),

2
pavelib/utils/test/suites/js_suite.py
View File

@@ -77,7 +77,7 @@ class JsTestSubSuite(TestSuite):
Run the tests using karma runner. Run the tests using karma runner.
""" """
cmd = [ cmd = [
"nodejs", "node",
"--max_old_space_size=4096", "--max_old_space_size=4096",
"node_modules/.bin/karma", "node_modules/.bin/karma",
"start", "start",