From 73d3b1450067eb3dda672c4cce2b8d7287a512de Mon Sep 17 00:00:00 2001 From: Greg Price Date: Fri, 7 Jun 2013 11:53:26 -0400 Subject: [PATCH] Add more information to Zendesk tickets and make the information more readable --- .../util/tests/test_submit_feedback.py | 16 +++++++++++----- common/djangoapps/util/views.py | 9 +++++++-- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/common/djangoapps/util/tests/test_submit_feedback.py b/common/djangoapps/util/tests/test_submit_feedback.py index b50c97f0ac..e063da1b21 100644 --- a/common/djangoapps/util/tests/test_submit_feedback.py +++ b/common/djangoapps/util/tests/test_submit_feedback.py @@ -49,7 +49,9 @@ class SubmitFeedbackTest(TestCase): "/submit_feedback", data=fields, HTTP_REFERER="test_referer", - HTTP_USER_AGENT="test_user_agent" + HTTP_USER_AGENT="test_user_agent", + REMOTE_ADDR="1.2.3.4", + SERVER_NAME="test_server" ) req.user = user return views.submit_feedback(req) @@ -159,8 +161,10 @@ class SubmitFeedbackTest(TestCase): "public": False, "body": "Additional information:\n\n" - "HTTP_USER_AGENT: test_user_agent\n" - "HTTP_REFERER: test_referer" + "Client IP: 1.2.3.4\n" + "Host: test_server\n" + "Page: test_referer\n" + "Browser: test_user_agent" } } } @@ -212,8 +216,10 @@ class SubmitFeedbackTest(TestCase): "body": "Additional information:\n\n" "username: test\n" - "HTTP_USER_AGENT: test_user_agent\n" - "HTTP_REFERER: test_referer" + "Client IP: 1.2.3.4\n" + "Host: test_server\n" + "Page: test_referer\n" + "Browser: test_user_agent" } } } diff --git a/common/djangoapps/util/views.py b/common/djangoapps/util/views.py index 3bf760c66f..a240d1646f 100644 --- a/common/djangoapps/util/views.py +++ b/common/djangoapps/util/views.py @@ -190,8 +190,13 @@ def submit_feedback(request): except ValidationError: return build_error_response(400, "email", required_field_errs["email"]) - for header in ["HTTP_REFERER", "HTTP_USER_AGENT"]: - additional_info[header] = request.META.get(header) + for header, pretty in [ + ("HTTP_REFERER", "Page"), + ("HTTP_USER_AGENT", "Browser"), + ("REMOTE_ADDR", "Client IP"), + ("SERVER_NAME", "Host") + ]: + additional_info[pretty] = request.META.get(header) success = _record_feedback_in_zendesk(realname, email, subject, details, tags, additional_info) _record_feedback_in_datadog(tags)