From 7368c3428f4bcea549f58a9595a06b56acf6d733 Mon Sep 17 00:00:00 2001 From: Ahsan Ulhaq Date: Tue, 25 Oct 2016 23:28:09 +0500 Subject: [PATCH] use reverse --- common/djangoapps/student/tests/test_helpers.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/common/djangoapps/student/tests/test_helpers.py b/common/djangoapps/student/tests/test_helpers.py index 6ff4032aa1..687fbfd396 100644 --- a/common/djangoapps/student/tests/test_helpers.py +++ b/common/djangoapps/student/tests/test_helpers.py @@ -2,6 +2,7 @@ import logging +from django.core.urlresolvers import reverse from django.test import TestCase from django.test.client import RequestFactory from testfixtures import LogCapture @@ -20,14 +21,16 @@ class TestLoginHelper(TestCase): def test_unsafe_next(self): """ Test unsafe next parameter """ + unsafe_url = "https://www.amazon.com" with LogCapture(LOGGER_NAME, level=logging.ERROR) as logger: - req = self.request.get("http://testserver/login?next=http://amazon.com") + req = self.request.get(reverse("login") + "?next={url}".format(url=unsafe_url)) get_next_url_for_login_page(req) logger.check( - (LOGGER_NAME, "ERROR", u"Unsafe redirect parameter detected: u'http://amazon.com'")) + (LOGGER_NAME, "ERROR", u"Unsafe redirect parameter detected: u'{url}'".format(url=unsafe_url)) + ) def test_safe_next(self): """ Test safe next parameter """ - req = self.request.get("http://testserver/login?next=/dashboard") + req = self.request.get(reverse("login") + "?next={url}".format(url="/dashboard")) next_page = get_next_url_for_login_page(req) self.assertEqual(next_page, u'/dashboard')