From 731d076cdc2cd38e5d55d4c21dbe0a26a434ae6c Mon Sep 17 00:00:00 2001 From: Julia Eskew Date: Thu, 21 Feb 2019 12:20:47 -0500 Subject: [PATCH] Add app_name prefix to the generated PII report. --- pavelib/paver_tests/test_pii_check.py | 4 ++-- pavelib/quality.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pavelib/paver_tests/test_pii_check.py b/pavelib/paver_tests/test_pii_check.py index 83b716fe23..95a64646ad 100644 --- a/pavelib/paver_tests/test_pii_check.py +++ b/pavelib/paver_tests/test_pii_check.py @@ -1,7 +1,7 @@ """ Tests for Paver's PII checker task. """ -from io import open +import io import six from mock import patch from paver.easy import call_task @@ -31,4 +31,4 @@ def test_pii_check_report_dir_override(mock_paver_sh, mock_needs, tmpdir): assert any(['cms.envs.test' in call for call in mock_calls]) assert all([six.text_type(report_dir) in call for call in mock_calls]) metrics_file = Env.METRICS_DIR / 'pii' - assert open(metrics_file, 'r').read() == '66' + assert io.open(metrics_file, 'r').read() == '66' diff --git a/pavelib/quality.py b/pavelib/quality.py index 3676a7d864..017ae98331 100644 --- a/pavelib/quality.py +++ b/pavelib/quality.py @@ -808,9 +808,9 @@ def run_pii_check(options): # pylint: disable=unused-argument "mkdir -p {} && " "export DJANGO_SETTINGS_MODULE={}; " "code_annotations django_find_annotations " - "--config_file .pii_annotations.yml --report_path {} " + "--config_file .pii_annotations.yml --report_path {} --app_name {} " "--lint --report --coverage | tee {}".format( - report_dir, env_settings_file, report_dir, run_output_file + report_dir, env_settings_file, report_dir, env_name.lower(), run_output_file ) ) uncovered_model_counts.append(_extract_missing_pii_annotations(run_output_file))