From c6d160ad1edac45753e3dc61e238a7def41a526b Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Thu, 26 Jul 2012 10:48:55 -0400 Subject: [PATCH 1/2] Ignore some spurious errors from pylint --- .pylintrc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.pylintrc b/.pylintrc index 54e2f5c8a9..ce2f2e3b87 100644 --- a/.pylintrc +++ b/.pylintrc @@ -33,7 +33,7 @@ load-plugins= # can either give multiple identifier separated by comma (,) or put this option # multiple time (only on the command line, not in the configuration file where # it should appear only once). -#disable= +disable=E1102,W0142 [REPORTS] @@ -82,7 +82,7 @@ zope=no # List of members which are set dynamically and missed by pylint inference # system, and so shouldn't trigger E0201 when accessed. Python regular # expressions are accepted. -generated-members=REQUEST,acl_users,aq_parent +generated-members=REQUEST,acl_users,aq_parent,objects,DoesNotExist,can_read,can_write,get_url,size [BASIC] From 1d554c76a038841d23c77cdfe5910b89443ecccf Mon Sep 17 00:00:00 2001 From: Calen Pennington Date: Thu, 26 Jul 2012 12:05:23 -0400 Subject: [PATCH 2/2] Comment out really loud debug messages from xml.py --- common/lib/xmodule/xmodule/modulestore/xml.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/lib/xmodule/xmodule/modulestore/xml.py b/common/lib/xmodule/xmodule/modulestore/xml.py index b8e86b97f1..3981009cef 100644 --- a/common/lib/xmodule/xmodule/modulestore/xml.py +++ b/common/lib/xmodule/xmodule/modulestore/xml.py @@ -53,8 +53,9 @@ class XMLModuleStore(ModuleStore): class_ = getattr(import_module(module_path), class_name) self.default_class = class_ - log.debug('XMLModuleStore: eager=%s, data_dir = %s' % (eager, self.data_dir)) - log.debug('default_class = %s' % self.default_class) + # TODO (cpennington): We need a better way of selecting specific sets of debug messages to enable. These were drowning out important messages + #log.debug('XMLModuleStore: eager=%s, data_dir = %s' % (eager, self.data_dir)) + #log.debug('default_class = %s' % self.default_class) for course_dir in os.listdir(self.data_dir): if course_dirs is not None and course_dir not in course_dirs: