From 71f237d3615a87596e9171c1fd6842a2ace840bd Mon Sep 17 00:00:00 2001 From: Jesse Zoldak Date: Fri, 31 Oct 2014 11:51:28 -0400 Subject: [PATCH] Revert "Fix lettuce css_fill method for devstack" This reverts commit 471abb8c28dc166653b1e032a1b68bdf79a5077e. --- common/djangoapps/terrain/ui_helpers.py | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/common/djangoapps/terrain/ui_helpers.py b/common/djangoapps/terrain/ui_helpers.py index 224aacc005..09028a7fc5 100644 --- a/common/djangoapps/terrain/ui_helpers.py +++ b/common/djangoapps/terrain/ui_helpers.py @@ -526,23 +526,7 @@ def css_fill(css_selector, text, index=0): Then for synchronization purposes, wait for the value on the page. """ wait_for_visible(css_selector, index=index) - - # HACK: - # At some point, in devstack strings were no longer being filled into fields - # correctly under our original implementation which used splinter's fill method. - # Instead everything after certain letters (E.g. e and r) was getting truncated. - # - # Note that troubleshooting showed that this happened both with the splinter "fill" - # method, and directly with its underlying selenium implementation which is - # self._element.clear() followed by self._element.send_keys(value) - # - # As a workaround, wait for the element to be visible, then use JS to set its value. - retry_on_exception(lambda: css_find(css_selector)[index] is not None) - world.browser.driver.execute_script('window.jQuery("{css_selector}").val("{text}");'.format( - css_selector=css_selector, - text=text - )) - + retry_on_exception(lambda: css_find(css_selector)[index].fill(text)) wait_for(lambda _: css_has_value(css_selector, text, index=index)) return True