From 714d3b96626018fa4ce56e70e36500f1583bebd7 Mon Sep 17 00:00:00 2001
From: David Baumgold <david@davidbaumgold.com>
Date: Tue, 6 Aug 2013 14:36:13 -0400
Subject: [PATCH] pylint fixes

---
 lms/djangoapps/instructor/tests/test_api.py | 16 +++++++---------
 lms/djangoapps/instructor/views/api.py      | 10 +++++-----
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/lms/djangoapps/instructor/tests/test_api.py b/lms/djangoapps/instructor/tests/test_api.py
index d546805a5e..cc2e23e8fe 100644
--- a/lms/djangoapps/instructor/tests/test_api.py
+++ b/lms/djangoapps/instructor/tests/test_api.py
@@ -1,6 +1,7 @@
 """
 Unit tests for instructor.api methods.
 """
+# pylint: disable=E1111
 import unittest
 import json
 from urllib import quote
@@ -28,24 +29,27 @@ from instructor_task.api_helper import AlreadyRunningError
 
 
 @common_exceptions_400
-def view_success(request):
+def view_success(request):  # pylint: disable=W0613
     "A dummy view for testing that returns a simple HTTP response"
     return HttpResponse('success')
 
 
 @common_exceptions_400
-def view_user_doesnotexist(request):
+def view_user_doesnotexist(request):  # pylint: disable=W0613
     "A dummy view that raises a User.DoesNotExist exception"
     raise User.DoesNotExist()
 
 
 @common_exceptions_400
-def view_alreadyrunningerror(request):
+def view_alreadyrunningerror(request):  # pylint: disable=W0613
     "A dummy view that raises an AlreadyRunningError exception"
     raise AlreadyRunningError()
 
 
 class TestCommonExceptions400(unittest.TestCase):
+    """
+    Testing the common_exceptions_400 decorator.
+    """
     def setUp(self):
         self.request = Mock(spec=HttpRequest)
         self.request.META = {}
@@ -749,12 +753,6 @@ class TestInstructorAPITaskLists(ModuleStoreTestCase, LoginEnrollmentTestCase):
         self.assertEqual(json.loads(response.content), expected_res)
 
 
-
-    # class TestInstructorAPILevelsForums
-    # # list_forum_members
-    # # update_forum_role_membership
-
-
 class TestInstructorAPIHelpers(TestCase):
     """ Test helpers for instructor.api """
     def test_split_input_list(self):
diff --git a/lms/djangoapps/instructor/views/api.py b/lms/djangoapps/instructor/views/api.py
index 64d70232f8..7655fd5b13 100644
--- a/lms/djangoapps/instructor/views/api.py
+++ b/lms/djangoapps/instructor/views/api.py
@@ -189,7 +189,7 @@ def students_update_enrollment(request, course_id):
             })
         # catch and log any exceptions
         # so that one error doesn't cause a 500.
-        except Exception as exc:
+        except Exception as exc:  # pylint: disable=W0703
             log.exception("Error while #{}ing student")
             log.exception(exc)
             results.append({
@@ -401,10 +401,10 @@ def get_distribution(request, course_id):
     if not feature is None:
         p_dist = analytics.distributions.profile_distribution(course_id, feature)
         response_payload['feature_results'] = {
-            'feature':  p_dist.feature,
-            'feature_display_name':  p_dist.feature_display_name,
-            'data':  p_dist.data,
-            'type':  p_dist.type,
+            'feature': p_dist.feature,
+            'feature_display_name': p_dist.feature_display_name,
+            'data': p_dist.data,
+            'type': p_dist.type,
         }
 
         if p_dist.type == 'EASY_CHOICE':