From 221f4e2363cefebb57ca888d36d13140a435642e Mon Sep 17 00:00:00 2001 From: Alexander Kryklia Date: Thu, 3 Apr 2014 14:34:12 +0300 Subject: [PATCH] Fix flaky video test #21: increase timeout. --- .../courseware/features/video.feature | 39 +++++++++---------- lms/djangoapps/courseware/features/video.py | 2 +- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/lms/djangoapps/courseware/features/video.feature b/lms/djangoapps/courseware/features/video.feature index 05adcb090e..4193944370 100644 --- a/lms/djangoapps/courseware/features/video.feature +++ b/lms/djangoapps/courseware/features/video.feature @@ -219,23 +219,22 @@ Feature: LMS Video component When I open video "C" Then menu "download_transcript" doesn't exist - # BLD-971 - Test intermittently failing - # 20 -# Scenario: Youtube video has correct transcript if fields for other speeds are filled. -# Given I am registered for the course "test_course" -# And I have a "subs_OEoXaMPEzfM.srt.sjson" transcript file in assets -# And I have a "subs_b7xgknqkQk8.srt.sjson" transcript file in assets -# And it has a video in "Youtube" mode: -# | sub | youtube_id_1_5 | -# | OEoXaMPEzfM | b7xgknqkQk8 | -# And I make sure captions are opened -# Then I see "Hi, welcome to Edx." text in the captions -# And I select the "1.50" speed -# And I reload the page -# Then I see "Hi, welcome to Edx." text in the captions -# And I see duration "1:00" - # 21 + Scenario: Youtube video has correct transcript if fields for other speeds are filled. + Given I am registered for the course "test_course" + And I have a "subs_OEoXaMPEzfM.srt.sjson" transcript file in assets + And I have a "subs_b7xgknqkQk8.srt.sjson" transcript file in assets + And it has a video in "Youtube" mode: + | sub | youtube_id_1_5 | + | OEoXaMPEzfM | b7xgknqkQk8 | + And I make sure captions are opened + Then I see "Hi, welcome to Edx." text in the captions + And I select the "1.50" speed + And I reload the page + Then I see "Hi, welcome to Edx." text in the captions + And I see duration "1:00" + + # 22 Scenario: Download button works correctly for non-english transcript in Youtube mode of Video component Given I am registered for the course "test_course" And I have a "chinese_transcripts.srt" transcript file in assets @@ -249,7 +248,7 @@ Feature: LMS Video component And I see "好 各位同学" text in the captions Then I can download transcript in "srt" format that has text "好 各位同学" - # 22 + # 23 Scenario: Download button works correctly for non-english transcript in HTML5 mode of Video component Given I am registered for the course "test_course" And I have a "chinese_transcripts.srt" transcript file in assets @@ -263,7 +262,7 @@ Feature: LMS Video component And I see "好 各位同学" text in the captions Then I can download transcript in "srt" format that has text "好 各位同学" - # 23 + # 24 Scenario: Download button works correctly w/o english transcript in HTML5 mode of Video component Given I am registered for the course "test_course" And I have a "chinese_transcripts.srt" transcript file in assets @@ -273,7 +272,7 @@ Feature: LMS Video component And I see "好 各位同学" text in the captions Then I can download transcript in "srt" format that has text "好 各位同学" - # 24 + # 25 Scenario: Download button works correctly w/o english transcript in Youtube mode of Video component Given I am registered for the course "test_course" And I have a "chinese_transcripts.srt" transcript file in assets @@ -283,7 +282,7 @@ Feature: LMS Video component And I see "好 各位同学" text in the captions Then I can download transcript in "srt" format that has text "好 各位同学" - # 25 + # 26 Scenario: Verify that each video in each sub-section includes a transcript for non-Youtube countries. Given youtube server is up and response time is 2 seconds And I am registered for the course "test_course" diff --git a/lms/djangoapps/courseware/features/video.py b/lms/djangoapps/courseware/features/video.py index 35cf6fed2b..98f262bc18 100644 --- a/lms/djangoapps/courseware/features/video.py +++ b/lms/djangoapps/courseware/features/video.py @@ -469,7 +469,7 @@ def start_playing_video_from_n_seconds(_step, position): def i_see_duration(_step, position): world.wait_for( func=lambda _: duration() == parse_time_str(position), - timeout=5 + timeout=30 )