From 6fc75c834b23618604c60f8a1d2f27a88ece53fc Mon Sep 17 00:00:00 2001 From: Robert Raposa Date: Fri, 6 Dec 2019 16:19:52 -0500 Subject: [PATCH] fix flaky test_login unit test ARCH-1253 --- openedx/core/djangoapps/user_authn/views/tests/test_login.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openedx/core/djangoapps/user_authn/views/tests/test_login.py b/openedx/core/djangoapps/user_authn/views/tests/test_login.py index 961fcc3ec5..967f121c4d 100644 --- a/openedx/core/djangoapps/user_authn/views/tests/test_login.py +++ b/openedx/core/djangoapps/user_authn/views/tests/test_login.py @@ -719,7 +719,7 @@ class LoginSessionViewTest(ApiTestCase): @patch('openedx.core.djangoapps.user_authn.views.login.segment') def test_login(self, include_analytics, mock_segment): # Create a test user - UserFactory.create(username=self.USERNAME, email=self.EMAIL, password=self.PASSWORD) + user = UserFactory.create(username=self.USERNAME, email=self.EMAIL, password=self.PASSWORD) data = { "email": self.EMAIL, @@ -743,7 +743,7 @@ class LoginSessionViewTest(ApiTestCase): self.assertHttpOK(response) # Verify events are called - expected_user_id = 1 + expected_user_id = user.id mock_segment.identify.assert_called_once_with( expected_user_id, {'username': self.USERNAME, 'email': self.EMAIL},