Correct publish titles, code review feedback.

cms/templates/js/course-outline.underscore

@@ -2,28 +2,20 @@
 var category = xblockInfo.get('category');
 var releasedToStudents = xblockInfo.get('released_to_students');
 var visibilityState = xblockInfo.get('visibility_state');
-
-var listType = 'list-unknown';
-if (xblockType === 'course') {
-    listType = 'list-sections';
-} else if (xblockType === 'section') {
-    listType = 'list-subsections';
-} else if (xblockType === 'subsection') {
-    listType = 'list-units';
-}
+var published = xblockInfo.get('published');
 
 var statusMessage = null;
 var statusType = null;
 if (visibilityState === 'staff_only') {
     statusType = 'staff-only';
-    statusMessage = 'Contains staff only content';
+    statusMessage = gettext('Contains staff only content');
 } else if (visibilityState === 'needs_attention') {
     if (category === 'vertical') {
         statusType = 'warning';
-        if (releasedToStudents) {
-            statusMessage = 'Unpublished changes to live content';
+        if (published && releasedToStudents) {
+            statusMessage = gettext('Unpublished changes to live content');
         } else {
-            statusMessage = 'Unpublished units will not be released';
+            statusMessage = gettext('Unpublished units will not be released');
         }
     }
 }
@@ -75,7 +67,7 @@ if (statusType === 'warning') {
         <% if (category !== 'vertical') { %>
             <div class="status-release">
                 <p>
-                    <span class="sr status-release-label">Release Status:</span>
+                    <span class="sr status-release-label"><%= gettext('Release Status:') %></span>
                     <span class="status-release-value">
                         <% if (xblockInfo.get('released_to_students')) { %>
                             <i class="icon icon-check-sign"></i>
@@ -115,7 +107,7 @@ if (statusType === 'warning') {
         </div>
     <% } else { %>
         <div class="outline-content <%= xblockType %>-content">
-            <ol class="<%= listType %> is-sortable">
+            <ol class="<%= typeListClass %> is-sortable">
             </ol>
             <% if (childType) { %>
                 <div class="add-<%= childType %> add-item">

cms/templates/js/publish-xblock.underscore

@@ -4,9 +4,9 @@ if (visibilityState === 'staff_only') {
     title = gettext("Unpublished (Staff only)");
 } else if (visibilityState === 'live') {
     title = gettext("Published and Live");
-} else if (visibilityState === 'ready') {
+} else if (published && !hasChanges) {
     title = gettext("Published");
-} else if (visibilityState === 'needs_attention') {
+} else if (published && hasChanges) {
     title = gettext("Draft (Unpublished changes)");
 }
 
@@ -19,7 +19,7 @@ if (visibilityState === 'live') {
 
 var visibleToStaffOnly = visibilityState === 'staff_only';
 %>
-<div class="bit-publishing <%= visibilityClass %>">
+<div class="bit-publishing <%= visibilityClass %> <% if (releaseDate) { %>is-scheduled<% } %>">
     <h3 class="bar-mod-title pub-status"><span class="sr"><%= gettext("Publishing Status") %></span>
         <%= title %>
     </h3>

cms/templates/js/unit-outline.underscore

@@ -1,13 +1,3 @@
-<%
-var listType = 'list-for-' + xblockType;
-if (xblockType === 'course') {
-    listType = 'list-sections';
-} else if (xblockType === 'section') {
-    listType = 'list-subsections';
-} else if (xblockType === 'subsection') {
-    listType = 'list-units';
-}
-%>
 <% if (parentInfo) { %>
     <li class="outline-item outline-<%= xblockType %> <%= visibilityClass %>"
         data-parent="<%= parentInfo.get('id') %>" data-locator="<%= xblockInfo.get('id') %>">
@@ -21,7 +11,7 @@ if (xblockType === 'course') {
 <% } %>
 
         <div class="<%= xblockType %>-content outline-content">
-            <ol class="<%= listType %>">
+            <ol class="<%= typeListClass %>">
             </ol>
             <% if (childType) { %>
                 <div class="add-<%= childType %> add-item">