From 69cab9671482978b45ae3ae2e86bdb3a83317e09 Mon Sep 17 00:00:00 2001 From: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> Date: Thu, 3 Aug 2023 15:52:34 -0400 Subject: [PATCH] feat: remove 403 for disabled advanced settings (#32906) --- .../contentstore/rest_api/v0/views/advanced_settings.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cms/djangoapps/contentstore/rest_api/v0/views/advanced_settings.py b/cms/djangoapps/contentstore/rest_api/v0/views/advanced_settings.py index 7c3de4fa79..7516bba372 100644 --- a/cms/djangoapps/contentstore/rest_api/v0/views/advanced_settings.py +++ b/cms/djangoapps/contentstore/rest_api/v0/views/advanced_settings.py @@ -3,7 +3,6 @@ from django import forms import edx_api_doc_tools as apidocs from opaque_keys.edx.keys import CourseKey -from rest_framework import status from rest_framework.exceptions import ValidationError from rest_framework.request import Request from rest_framework.response import Response @@ -12,7 +11,6 @@ from xmodule.modulestore.django import modulestore from cms.djangoapps.models.settings.course_metadata import CourseMetadata from cms.djangoapps.contentstore.api.views.utils import get_bool_param -from cms.djangoapps.contentstore.toggles import use_new_advanced_settings_page from common.djangoapps.student.auth import has_studio_read_access, has_studio_write_access from openedx.core.lib.api.view_utils import DeveloperErrorViewMixin, verify_course_exists, view_auth_classes from ..serializers import CourseAdvancedSettingsSerializer @@ -117,8 +115,6 @@ class AdvancedCourseSettingsView(DeveloperErrorViewMixin, APIView): if not filter_query_data.is_valid(): raise ValidationError(filter_query_data.errors) course_key = CourseKey.from_string(course_id) - if not use_new_advanced_settings_page(course_key): - return Response(status=status.HTTP_403_FORBIDDEN) if not has_studio_read_access(request.user, course_key): self.permission_denied(request) course_block = modulestore().get_course(course_key)