Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't fall over if a model doesn't have actions defined

Browse Source 
It appears that one notification stealing focus from another causes some weirdness:
both clicking on a button on one view triggers the event on both views (the original
and the new view that stole the div). As long as the first view does *not* define
any click events, everything is fine -- this is the case for the saving notification.
I'll worry about the reason for this later; it has something to do with views
listening to models even after they no longer should be.
This commit is contained in:
David Baumgold
2013-05-10 16:50:37 -04:00
parent 1333717871
commit 69a6ec0c97
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cms/static/js/views/feedback.js
View File

@@ -24,16 +24,19 @@ CMS.Views.SystemFeedback = Backbone.View.extend({
this.model.hide(); this.model.hide();
}, },
primaryClick: function() { primaryClick: function() {
var primary = this.model.get("actions").primary; var actions = this.model.get("actions");
if(!actions) { return; }
var primary = actions.primary;
if(!primary) { return; }
if(primary.click) { if(primary.click) {
primary.click.call(this.model); primary.click.call(this.model);
} }
}, },
secondaryClick: function(e) { secondaryClick: function(e) {
var secondaryList = this.model.get("actions").secondary; var actions = this.model.get("actions");
if(!secondaryList) { if(!actions) { return; }
return; var secondaryList = actions.secondary;
} if(!secondaryList) { return; }
// which secondary action was clicked? // which secondary action was clicked?
var i = _.indexOf(this.$(".action-secondary"), e.target); var i = _.indexOf(this.$(".action-secondary"), e.target);
var secondary = this.model.get("actions").secondary[i]; var secondary = this.model.get("actions").secondary[i];