diff --git a/common/static/common/js/discussion/utils.js b/common/static/common/js/discussion/utils.js index 83ff8bcd67..d4f8fcc21c 100644 --- a/common/static/common/js/discussion/utils.js +++ b/common/static/common/js/discussion/utils.js @@ -127,7 +127,8 @@ DiscussionUtil.showLoadingIndicator = function(element, takeFocus) { var animElem = edx.HtmlUtils.joinHtml( - edx.HtmlUtils.HTML("
"), + edx.HtmlUtils.HTML("
"), + edx.HtmlUtils.HTML(""), gettext('Loading content'), edx.HtmlUtils.HTML('
') ); diff --git a/common/static/common/js/discussion/views/discussion_inline_view.js b/common/static/common/js/discussion/views/discussion_inline_view.js index 1a80011b5b..891ab7523e 100644 --- a/common/static/common/js/discussion/views/discussion_inline_view.js +++ b/common/static/common/js/discussion/views/discussion_inline_view.js @@ -193,6 +193,7 @@ }); } } + this.toggleDiscussionBtn.focus(); }, hideDiscussion: function() { diff --git a/common/static/common/templates/discussion/post-user-display.underscore b/common/static/common/templates/discussion/post-user-display.underscore index 515538fce3..e7bacbaf4c 100644 --- a/common/static/common/templates/discussion/post-user-display.underscore +++ b/common/static/common/templates/discussion/post-user-display.underscore @@ -1,9 +1,9 @@ <% if (username) { %> <%- username %> <% if (is_community_ta) { %> - <%- gettext("Community TA") %> + <%- gettext("(Community TA)") %> <% } else if (is_staff) { %> - <%- gettext("Staff") %> + <%- gettext("(Staff)") %> <% } %> <% } else { %> <%- gettext('anonymous') %> diff --git a/lms/static/sass/base/_base.scss b/lms/static/sass/base/_base.scss index f9f48ead04..e5d4a2c1e8 100644 --- a/lms/static/sass/base/_base.scss +++ b/lms/static/sass/base/_base.scss @@ -183,12 +183,9 @@ span.edx { } .loading-animation { - position: absolute; - left: 50%; - width: 20px; - height: 20px; - margin-left: -($baseline/2); - background: url('#{$static-path}/images/spinner.gif') no-repeat; + @include animation(fa-spin 2s infinite linear); + text-align: center; + width: 100%; } mark { diff --git a/lms/static/sass/discussion/_discussion.scss b/lms/static/sass/discussion/_discussion.scss index c1c3e239b8..5c6f16aa3c 100644 --- a/lms/static/sass/discussion/_discussion.scss +++ b/lms/static/sass/discussion/_discussion.scss @@ -86,9 +86,6 @@ margin-bottom: $baseline; } - .loading-animation { - background-image: url('#{$static-path}/images/spinner.gif'); - } } .discussion-show { diff --git a/lms/static/sass/discussion/_mixins.scss b/lms/static/sass/discussion/_mixins.scss index 7347a67b04..73c4b25cde 100644 --- a/lms/static/sass/discussion/_mixins.scss +++ b/lms/static/sass/discussion/_mixins.scss @@ -87,16 +87,3 @@ white-space: nowrap; text-overflow: ellipsis; } - -@mixin forum-user-label($color) { - @include margin-left($baseline/4); - @extend %t-weight5; - font-size: $forum-small-font-size; - vertical-align: middle; - border-radius: $forum-border-radius; - padding: 0 ($baseline/5); - background: $color; - font-style: normal; - color: white; - white-space: nowrap; -} diff --git a/lms/static/sass/discussion/elements/_actions.scss b/lms/static/sass/discussion/elements/_actions.scss index 825b11b3a7..2aa2f9e645 100644 --- a/lms/static/sass/discussion/elements/_actions.scss +++ b/lms/static/sass/discussion/elements/_actions.scss @@ -135,6 +135,7 @@ color: $gray-l1; .icon { + @include margin-right(0); vertical-align: middle; } } diff --git a/lms/static/sass/discussion/elements/_labels.scss b/lms/static/sass/discussion/elements/_labels.scss index 8d0936549c..3930034aaa 100644 --- a/lms/static/sass/discussion/elements/_labels.scss +++ b/lms/static/sass/discussion/elements/_labels.scss @@ -42,13 +42,13 @@ } } - .user-label-staff { - @include forum-user-label($forum-color-staff); + .user-label-staff, + .user-label-community-ta { + color: $forum-color-copy-light; + font-size: $forum-small-font-size; + white-space: nowrap; } - .user-label-community-ta { - @include forum-user-label($forum-color-community-ta); - } } // Make post labels tighter when shown inside the left nav diff --git a/lms/templates/discussion/_thread_list_template.html b/lms/templates/discussion/_thread_list_template.html index 3afffaaee3..865ef2cf02 100644 --- a/lms/templates/discussion/_thread_list_template.html +++ b/lms/templates/discussion/_thread_list_template.html @@ -8,12 +8,12 @@ ${_("Filter:")}