From 68714d9e97de002ab265aa59ced5dd68628e4f1c Mon Sep 17 00:00:00 2001
From: Douglas Cerna <douglascerna@yahoo.com>
Date: Thu, 6 Jul 2017 20:50:50 -0600
Subject: [PATCH] Fixed quality errors

---
 .../views/discussion_inline_view.js           |  2 +-
 .../js/discussion/views/new_post_view.js      | 22 +++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/common/static/common/js/discussion/views/discussion_inline_view.js b/common/static/common/js/discussion/views/discussion_inline_view.js
index 870a9fcda6..acedb3e62e 100644
--- a/common/static/common/js/discussion/views/discussion_inline_view.js
+++ b/common/static/common/js/discussion/views/discussion_inline_view.js
@@ -127,7 +127,7 @@
                 topicId: discussionId,
                 startHeader: this.startHeader,
                 is_commentable_divided: response.is_commentable_divided,
-                user_group_id: response.user_group_id,
+                user_group_id: response.user_group_id
             });
 
             this.newPostView.render();
diff --git a/common/static/common/js/discussion/views/new_post_view.js b/common/static/common/js/discussion/views/new_post_view.js
index bb1ba7b155..048eff1672 100644
--- a/common/static/common/js/discussion/views/new_post_view.js
+++ b/common/static/common/js/discussion/views/new_post_view.js
@@ -112,21 +112,21 @@
             NewPostView.prototype.getGroupName = function() {
                 var userGroupId;
                 var group;
-                var group_name = null;
+                var groupName = null;
                 if (this.course_settings.get('is_discussion_division_enabled')) {
                     userGroupId = $('#discussion-container').data('user-group-id');
                     if (!userGroupId) {
                         userGroupId = this.user_group_id;
                     }
-                    group = this.course_settings.get('groups').find(function(group) {
-                        return group.id == userGroupId;
+                    group = this.course_settings.get('groups').find(function(courseSettingsGroup) {
+                        return courseSettingsGroup.id === String(userGroupId);
                     });
                     if (group) {
-                        group_name = group.name;
+                        groupName = group.name;
                     }
                 }
 
-                return group_name;
+                return groupName;
             };
 
             NewPostView.prototype.events = {
@@ -150,15 +150,15 @@
                 }
             };
 
-            NewPostView.prototype.updateVisibilityMessage = function($target, force_divided) {
-                var visEl = $('.group-visibility .field-label-text');
+            NewPostView.prototype.updateVisibilityMessage = function($target, forceDivided) {
+                var $visEl = $('.group-visibility .field-label-text');
                 var visTemplate = edx.HtmlUtils.template($('#new-post-visibility-template').html());
-                var group_name = null;
-                if (($target && $target.data('divided')) || force_divided) {
-                    group_name = this.group_name;
+                var groupName = null;
+                if (($target && $target.data('divided')) || forceDivided) {
+                    groupName = this.group_name;
                 }
 
-                edx.HtmlUtils.setHtml(visEl, visTemplate({group_name: group_name}));
+                edx.HtmlUtils.setHtml($visEl, visTemplate({group_name: groupName}));
             };
 
             NewPostView.prototype.postOptionChange = function(event) {