From 85207225fc9b7916be787e2b566bd25c02ba8aae Mon Sep 17 00:00:00 2001 From: michaelroytman Date: Fri, 22 Jul 2022 10:19:27 -0400 Subject: [PATCH] fix: hidden lti_version and 1.3 fields in edit view and incorrect menu behavior in Javascript This commit updates the version of the lti-consumer-xblock from 4.3.0 to 4.3.1. This installs the newest version of the lti-consumer-xblock library. This version includes the following changes. This commit fixes three bugs. 1. The first bug is that the lti_version field is inappropriately hidden in the Studio author view edit menu when the selected config_type is database. 2. The second bug is that the editable_fields property of the LtiConsumerXBlock is inappropriately excluding LTI 1.3 fields when the config_type is database. The editable_fields property should include LTI 1.3 fields even when the config_type is database, because the Javascript defined in xblock_studio_view.js may want to show these fields if the user selects a different config_type in the menu. We want to support a dynamic edit menu, so these fields must be considered editable by the XBlock in order for the Javascript to be able to manipulate them. 3. The third bug is in inconsistent rendering of the Studio author view edit menu. Depending on the order in which a user selects lti_version, config_type, or lti_1p3_tool_key_mode, different sets of fields are displayed, due to the overlapping sets of rules that govern what fields should be hidden or shown for a given field selection. This commit corrects this inconsistent rendering by first showing all fields and then gradually hiding fields depending on the sets of rules, for each change to the fields. --- requirements/edx/base.txt | 2 +- requirements/edx/development.txt | 2 +- requirements/edx/testing.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/requirements/edx/base.txt b/requirements/edx/base.txt index b795677e27..adbc3470a1 100644 --- a/requirements/edx/base.txt +++ b/requirements/edx/base.txt @@ -658,7 +658,7 @@ libsass==0.10.0 # ora2 loremipsum==1.0.5 # via ora2 -lti-consumer-xblock==4.3.0 +lti-consumer-xblock==4.3.1 # via -r requirements/edx/base.in lxml==4.9.1 # via diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt index 9d51e77c21..615a5b3de4 100644 --- a/requirements/edx/development.txt +++ b/requirements/edx/development.txt @@ -862,7 +862,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/testing.txt # ora2 -lti-consumer-xblock==4.3.0 +lti-consumer-xblock==4.3.1 # via -r requirements/edx/testing.txt lxml==4.9.1 # via diff --git a/requirements/edx/testing.txt b/requirements/edx/testing.txt index b37dcf6bad..e4345c40da 100644 --- a/requirements/edx/testing.txt +++ b/requirements/edx/testing.txt @@ -820,7 +820,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/base.txt # ora2 -lti-consumer-xblock==4.3.0 +lti-consumer-xblock==4.3.1 # via -r requirements/edx/base.txt lxml==4.9.1 # via