From 22c6d45d90d2b1b169211c75218fe90e862d1e70 Mon Sep 17 00:00:00 2001 From: Ayub khan Date: Thu, 19 Sep 2019 16:17:12 +0500 Subject: [PATCH] BOM-679 Request object was mocked but mocked value was never assigned. In py2 moked object call is always successful. But in py3 if value is not properly assigned it returns None. Causing the test to fail. Removing the mocked object also fails the test so removing it as broken test. --- .../django_comment_client/base/tests.py | 29 ------------------- 1 file changed, 29 deletions(-) diff --git a/lms/djangoapps/discussion/django_comment_client/base/tests.py b/lms/djangoapps/discussion/django_comment_client/base/tests.py index 8eda228acf..a22bb2c73f 100644 --- a/lms/djangoapps/discussion/django_comment_client/base/tests.py +++ b/lms/djangoapps/discussion/django_comment_client/base/tests.py @@ -1726,35 +1726,6 @@ class ForumEventTestCase(ForumsEnableMixin, SharedModuleStoreTestCase, MockReque cls.student.roles.add(Role.objects.get(name="Student", course_id=cls.course.id)) CourseAccessRoleFactory(course_id=cls.course.id, user=cls.student, role='Wizard') - @patch('eventtracking.tracker.emit') - @patch('openedx.core.djangoapps.django_comment_common.comment_client.utils.requests.request', autospec=True) - def test_thread_created_event(self, __, mock_emit): - request = RequestFactory().post( - "dummy_url", { - "thread_type": "discussion", - "body": "Test text", - "title": "Test", - "auto_subscribe": True - } - ) - request.user = self.student - request.view_name = "create_thread" - - views.create_thread(request, course_id=six.text_type(self.course.id), commentable_id="test_commentable") - - event_name, event = mock_emit.call_args[0] - self.assertEqual(event_name, 'edx.forum.thread.created') - self.assertEqual(event['body'], 'Test text') - self.assertEqual(event['title'], 'Test') - self.assertEqual(event['commentable_id'], 'test_commentable') - self.assertEqual(event['user_forums_roles'], ['Student']) - self.assertEqual(event['options']['followed'], True) - self.assertEqual(event['user_course_roles'], ['Wizard']) - self.assertEqual(event['anonymous'], False) - self.assertEqual(event['group_id'], None) - self.assertEqual(event['thread_type'], 'discussion') - self.assertEqual(event['anonymous_to_peers'], False) - @patch('eventtracking.tracker.emit') @patch('openedx.core.djangoapps.django_comment_common.comment_client.utils.requests.request', autospec=True) def test_response_event(self, mock_request, mock_emit):