From f599d4b5086db4af2e7055d9cf3feeb8a6ec1322 Mon Sep 17 00:00:00 2001 From: Chris Dodge Date: Mon, 19 Aug 2013 11:05:27 -0400 Subject: [PATCH 1/2] don't put the substitutions in quotes --- lms/templates/dashboard.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lms/templates/dashboard.html b/lms/templates/dashboard.html index 1dfa66461c..2dd1a05f2c 100644 --- a/lms/templates/dashboard.html +++ b/lms/templates/dashboard.html @@ -140,11 +140,11 @@ % if course.id in show_courseware_links_for: - ${_('{course_number} {course_name} Cover Image').format(course_number='${course.number}', course_name='${course.display_name_with_default}') |h} + ${_('{course_number} {course_name} Cover Image').format(course_number=course.number, course_name=course.display_name_with_default) |h} % else:
- ${_('{course_number} {course_name} Cover Image').format(course_number='${course.number}', course_name='${course.display_name_with_default}')} + ${_('{course_number} {course_name} Cover Image').format(course_number=course.number, course_name=course.display_name_with_default)}
% endif From 2e1eb1dce52e319438b5bf8f169e60a1cbbb1154 Mon Sep 17 00:00:00 2001 From: Chris Dodge Date: Mon, 19 Aug 2013 11:42:16 -0400 Subject: [PATCH 2/2] add escaping --- lms/templates/dashboard.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lms/templates/dashboard.html b/lms/templates/dashboard.html index 2dd1a05f2c..5023345376 100644 --- a/lms/templates/dashboard.html +++ b/lms/templates/dashboard.html @@ -144,7 +144,7 @@ % else:
- ${_('{course_number} {course_name} Cover Image').format(course_number=course.number, course_name=course.display_name_with_default)} + ${_('{course_number} {course_name} Cover Image').format(course_number=course.number, course_name=course.display_name_with_default) | h}
% endif