diff --git a/lms/djangoapps/dashboard/sysadmin.py b/lms/djangoapps/dashboard/sysadmin.py index 9366122e6c..f7d9c70209 100644 --- a/lms/djangoapps/dashboard/sysadmin.py +++ b/lms/djangoapps/dashboard/sysadmin.py @@ -78,10 +78,7 @@ class SysadminDashboardView(TemplateView): def get_courses(self): """ Get an iterable list of courses.""" - courses = self.def_ms.get_courses() - courses = dict([c.id.to_deprecated_string(), c] for c in courses) # no course directory - - return courses + return self.def_ms.get_courses() def return_csv(self, filename, header, data): """ @@ -247,7 +244,6 @@ class Users(SysadminDashboardView): """Returns the datatable used for this view""" self.datatable = {} - courses = self.get_courses() self.datatable = dict(header=[_('Statistic'), _('Value')], title=_('Site statistics')) @@ -257,9 +253,9 @@ class Users(SysadminDashboardView): self.msg += u'
{1}').format(
- course_id, escape(str(err))
- )
+ self.msg += _(
+ 'Error - cannot get course with ID {0}{1}'
+ ).format(
+ course_key,
+ escape(str(err))
+ )
is_xml_course = (modulestore().get_modulestore_type(course_key) == XML_MODULESTORE_TYPE)
if course_found and is_xml_course:
@@ -599,9 +596,7 @@ class Staffing(SysadminDashboardView):
raise Http404
data = []
- courses = self.get_courses()
-
- for (cdir, course) in courses.items(): # pylint: disable=unused-variable
+ for course in self.get_courses(): # pylint: disable=unused-variable
datum = [course.display_name, course.id]
datum += [CourseEnrollment.objects.filter(
course_id=course.id).count()]
@@ -635,9 +630,7 @@ class Staffing(SysadminDashboardView):
data = []
roles = [CourseInstructorRole, CourseStaffRole, ]
- courses = self.get_courses()
-
- for (cdir, course) in courses.items(): # pylint: disable=unused-variable
+ for course in self.get_courses(): # pylint: disable=unused-variable
for role in roles:
for user in role(course.id).users_with_role():
datum = [course.id, role, user.username, user.email,