From 62718f2ed3fcd62ddcedc8ec22e1d7b8588842ba Mon Sep 17 00:00:00 2001 From: Ahtisham Shahid Date: Wed, 16 Aug 2023 19:33:13 +0500 Subject: [PATCH] fix: removed redundant unit update from task (#33017) --- openedx/core/djangoapps/discussions/tasks.py | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/openedx/core/djangoapps/discussions/tasks.py b/openedx/core/djangoapps/discussions/tasks.py index 2d87a8cca7..fea20dc59b 100644 --- a/openedx/core/djangoapps/discussions/tasks.py +++ b/openedx/core/djangoapps/discussions/tasks.py @@ -110,16 +110,9 @@ def get_discussable_units(course, enable_graded_units, discussable_units=None): for unit in get_units(subsection): idx += 1 if not is_discussable_unit(unit, store, enable_graded_units, subsection): - # TODO: if and log statement will be removed after testing. - if str(course.id) == "course-v1:NedX+CMH43+2023_Summer": - log.info(f"Checking discussions_enabled for {course.id}") - if unit.discussion_enabled: - unit.discussion_enabled = False - store.update_item(unit, unit.published_by, isPublish=True, emit_signals=False) - log.info(f"Updating discussions_enabled for {course.id}") - else: - unit.discussion_enabled = False - store.update_item(unit, unit.published_by, emit_signals=False) + if unit.discussion_enabled: + log.info(f"Unit {unit.location} of course {course.id} has discussion enabled " + f"but is not discussable") continue # check if discussable_units is type of list and discussable_units is empty # it means if discussable_units is empty then we should not create any topic