From 5d5fce2949ba5e892c345b4aae5b40830de370f6 Mon Sep 17 00:00:00 2001 From: michaelroytman Date: Wed, 3 Aug 2022 08:17:25 -0400 Subject: [PATCH] fix: missing exception details in xblock-lti-consumer logs This commit updates the version of the lti-consumer-xblock from 4.3.2 to 4.3.3. This installs the newest version of the lti-consumer-xblock library. This version includes the following changes. The error handler in LtiConsumerXBlock.lti_1p3_launch_callback logs a warning when a select set of exceptions are handled. That log does not contain useful information about the nature of the exception, because the exceptions were not being instantiated with error messages. The try...catch is a large block that contains code that can raise a multitude of errors, so these changes will enable better debugging. This commit: * adds helpful messages to the raised exceptions. * adds the "exc_info=True" argument to include the stack trace of the handled exception. * adds ValueError and TypeError to the list of handled exceptions, because the code can raise exceptions of these types. --- requirements/edx/base.txt | 2 +- requirements/edx/development.txt | 2 +- requirements/edx/testing.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/requirements/edx/base.txt b/requirements/edx/base.txt index 868ee1a132..dcc1e84fb9 100644 --- a/requirements/edx/base.txt +++ b/requirements/edx/base.txt @@ -656,7 +656,7 @@ libsass==0.10.0 # ora2 loremipsum==1.0.5 # via ora2 -lti-consumer-xblock==4.3.2 +lti-consumer-xblock==4.3.3 # via -r requirements/edx/base.in lxml==4.9.1 # via diff --git a/requirements/edx/development.txt b/requirements/edx/development.txt index b7fac205c4..90825a3e86 100644 --- a/requirements/edx/development.txt +++ b/requirements/edx/development.txt @@ -860,7 +860,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/testing.txt # ora2 -lti-consumer-xblock==4.3.2 +lti-consumer-xblock==4.3.3 # via -r requirements/edx/testing.txt lxml==4.9.1 # via diff --git a/requirements/edx/testing.txt b/requirements/edx/testing.txt index c87c97b8ac..d355eff673 100644 --- a/requirements/edx/testing.txt +++ b/requirements/edx/testing.txt @@ -818,7 +818,7 @@ loremipsum==1.0.5 # via # -r requirements/edx/base.txt # ora2 -lti-consumer-xblock==4.3.2 +lti-consumer-xblock==4.3.3 # via -r requirements/edx/base.txt lxml==4.9.1 # via