From 5bc6b31e29110d678c465eeb9cf68dd5f6f370f4 Mon Sep 17 00:00:00 2001 From: Eric Fischer Date: Fri, 8 Dec 2017 12:36:39 -0500 Subject: [PATCH] eslint --fix --- cms/static/cms/js/build.js | 2 +- cms/static/cms/js/main.js | 4 +- cms/static/cms/js/xblock/cms.runtime.v1.js | 8 +- cms/static/js/base.js | 3 +- .../certificates/collections/certificates.js | 3 +- .../js/certificates/spec/custom_matchers.js | 2 +- .../spec/views/certificate_details_spec.js | 4 +- .../certificates/views/certificate_details.js | 3 +- .../certificates/views/certificate_editor.js | 2 +- .../js/certificates/views/certificate_item.js | 4 +- .../certificates/views/signatory_details.js | 4 +- .../js/certificates/views/signatory_editor.js | 6 +- cms/static/js/factories/base.js | 2 +- cms/static/js/factories/login.js | 4 +- cms/static/js/factories/manage_users.js | 2 +- cms/static/js/factories/manage_users_lib.js | 2 +- cms/static/js/factories/settings_advanced.js | 15 +- cms/static/js/models/course.js | 2 +- cms/static/js/models/course_info.js | 4 +- cms/static/js/models/course_update.js | 10 +- cms/static/js/models/explicit_url.js | 2 +- cms/static/js/models/license.js | 20 +- cms/static/js/models/location.js | 22 +- cms/static/js/models/metadata.js | 14 +- cms/static/js/models/module_info.js | 8 +- cms/static/js/models/section.js | 2 +- .../js/models/settings/course_details.js | 2 +- .../js/models/settings/course_grader.js | 35 +- .../models/settings/course_grading_policy.js | 25 +- cms/static/js/models/textbook.js | 4 +- cms/static/js/models/uploads.js | 18 +- cms/static/js/models/validation_helpers.js | 2 +- cms/static/js/models/xblock_container_info.js | 2 +- cms/static/js/models/xblock_outline_info.js | 2 +- .../spec/factories/xblock_validation_spec.js | 16 +- .../js/spec/models/component_template_spec.js | 82 ++-- .../js/spec/models/explicit_url_spec.js | 2 +- .../spec/models/group_configuration_spec.js | 58 +-- cms/static/js/spec/models/license_spec.js | 22 +- cms/static/js/spec/models/xblock_info_spec.js | 30 +- .../js/spec/models/xblock_validation_spec.js | 98 ++-- .../js/spec/utils/drag_and_drop_spec.js | 6 +- .../spec/video/file_uploader_editor_spec.js | 4 +- .../js/spec/video/transcripts/editor_spec.js | 14 +- .../js/spec/video/transcripts/utils_spec.js | 6 +- .../spec/video/transcripts/videolist_spec.js | 2 +- .../js/spec/video/translations_editor_spec.js | 70 +-- cms/static/js/spec/views/assets_spec.js | 119 ++--- cms/static/js/spec/views/container_spec.js | 2 +- .../js/spec/views/group_configuration_spec.js | 26 +- cms/static/js/spec/views/license_spec.js | 18 +- cms/static/js/spec/views/login_studio_spec.js | 22 +- .../js/spec/views/modals/edit_xblock_spec.js | 4 +- .../views/modals/move_xblock_modal_spec.js | 4 +- cms/static/js/spec/views/module_edit_spec.js | 2 +- cms/static/js/spec/views/move_xblock_spec.js | 6 +- .../js/spec/views/paged_container_spec.js | 6 +- .../js/spec/views/pages/container_spec.js | 175 +++---- .../views/pages/container_subviews_spec.js | 23 +- .../spec/views/pages/course_outline_spec.js | 195 ++++---- .../js/spec/views/pages/course_rerun_spec.js | 48 +- cms/static/js/spec/views/pages/index_spec.js | 6 +- .../js/spec/views/pages/library_users_spec.js | 14 +- .../views/previous_video_upload_list_spec.js | 2 +- .../spec/views/previous_video_upload_spec.js | 2 +- .../js/spec/views/settings/main_spec.js | 18 +- cms/static/js/spec/views/unit_outline_spec.js | 4 +- .../js/spec/views/xblock_editor_spec.js | 6 +- cms/static/js/spec/views/xblock_spec.js | 2 +- .../views/xblock_string_field_editor_spec.js | 2 +- .../js/spec/views/xblock_validation_spec.js | 34 +- .../js/spec_helpers/assertion_helpers.js | 26 +- cms/static/js/spec_helpers/edit_helpers.js | 56 +-- cms/static/js/spec_helpers/modal_helpers.js | 26 +- .../js/spec_helpers/validation_helpers.js | 6 +- cms/static/js/utils/change_on_enter.js | 3 +- cms/static/js/utils/date_utils.js | 8 +- cms/static/js/utils/drag_and_drop.js | 76 ++- cms/static/js/utils/handle_iframe_binding.js | 3 +- cms/static/js/utils/modal.js | 3 +- cms/static/js/utils/module.js | 3 +- cms/static/js/views/abstract_editor.js | 3 +- cms/static/js/views/asset.js | 10 +- cms/static/js/views/assets.js | 17 +- cms/static/js/views/baseview.js | 6 +- cms/static/js/views/components/add_xblock.js | 8 +- cms/static/js/views/container.js | 6 +- cms/static/js/views/content_group_editor.js | 2 +- cms/static/js/views/course_info_handout.js | 6 +- cms/static/js/views/course_info_helper.js | 2 +- cms/static/js/views/course_info_update.js | 29 +- cms/static/js/views/course_outline.js | 11 +- cms/static/js/views/edit_chapter.js | 4 +- cms/static/js/views/edit_textbook.js | 6 +- .../js/views/group_configuration_editor.js | 4 +- .../js/views/group_configuration_item.js | 4 +- cms/static/js/views/license.js | 70 +-- cms/static/js/views/manage_users_and_roles.js | 9 +- cms/static/js/views/metadata.js | 34 +- .../js/views/modals/course_outline_modals.js | 39 +- cms/static/js/views/modals/edit_xblock.js | 14 +- cms/static/js/views/module_edit.js | 2 +- cms/static/js/views/paged_container.js | 12 +- .../js/views/pages/container_subviews.js | 10 +- cms/static/js/views/pages/course_outline.js | 23 +- cms/static/js/views/pages/paged_container.js | 4 +- cms/static/js/views/settings/advanced.js | 18 +- cms/static/js/views/settings/grader.js | 20 +- cms/static/js/views/settings/grading.js | 54 +-- cms/static/js/views/settings/main.js | 49 +- cms/static/js/views/show_textbook.js | 2 +- cms/static/js/views/tabs.js | 6 +- cms/static/js/views/unit_outline.js | 3 +- cms/static/js/views/uploads.js | 10 +- .../js/views/utils/create_utils_base.js | 3 +- cms/static/js/views/utils/xblock_utils.js | 12 +- cms/static/js/views/validation.js | 31 +- .../video/transcripts/metadata_videolist.js | 6 +- .../js/views/video/translations_editor.js | 26 +- cms/static/js/views/xblock.js | 10 +- cms/static/js/views/xblock_editor.js | 2 +- cms/static/js/views/xblock_outline.js | 10 +- cms/static/js/views/xblock_validation.js | 6 +- cms/static/js/xblock/authoring.js | 3 +- .../js/xblock_asides/structured_tags.js | 2 +- .../word_cloud/public/js/word_cloud_main.js | 2 +- .../xmodule/js/spec/capa/imageinput_spec.js | 6 +- .../xmodule/js/spec/collapsible_spec.js | 36 +- common/lib/xmodule/xmodule/js/spec/helper.js | 4 +- .../xmodule/xmodule/js/spec/main_requirejs.js | 6 +- .../js/spec/split_test/staff_view_spec.js | 14 +- .../xmodule/js/spec/video/general_spec.js | 7 +- .../xmodule/js/spec/video/html5_video_spec.js | 3 +- .../xmodule/js/spec/video/initialize_spec.js | 20 +- .../xmodule/js/spec/video/resizer_spec.js | 69 ++- .../js/spec/video/video_caption_spec.js | 66 +-- .../js/spec/video/video_context_menu_spec.js | 22 +- .../js/spec/video/video_control_spec.js | 45 +- .../video/video_events_bumper_plugin_spec.js | 8 +- .../js/spec/video/video_events_plugin_spec.js | 14 +- .../js/spec/video/video_full_screen_spec.js | 14 +- .../spec/video/video_play_placeholder_spec.js | 13 +- .../js/spec/video/video_player_spec.js | 23 +- .../spec/video/video_progress_slider_spec.js | 22 +- .../video/video_save_state_plugin_spec.js | 6 +- .../js/spec/video/video_speed_control_spec.js | 70 +-- .../js/spec/video/video_storage_spec.js | 10 +- .../spec/video/video_volume_control_spec.js | 30 +- .../xmodule/xmodule/js/spec/xmodule_spec.js | 40 +- .../xmodule/xmodule/js/src/capa/display.js | 1 - .../lib/xmodule/xmodule/js/src/collapsible.js | 8 +- .../xmodule/xmodule/js/src/html/imageModal.js | 6 +- .../xmodule/xmodule/js/src/poll/poll_main.js | 10 +- .../xmodule/js/src/video/00_component.js | 2 +- .../xmodule/xmodule/js/src/video/00_i18n.js | 22 +- .../xmodule/js/src/video/00_resizer.js | 32 +- .../xmodule/xmodule/js/src/video/00_sjson.js | 4 +- .../xmodule/js/src/video/01_initialize.js | 32 +- .../xmodule/js/src/video/04_video_control.js | 12 +- .../js/src/video/04_video_full_screen.js | 16 +- .../js/src/video/05_video_quality_control.js | 7 +- .../js/src/video/06_video_progress_slider.js | 10 +- .../js/src/video/07_video_volume_control.js | 46 +- .../js/src/video/08_video_speed_control.js | 20 +- .../js/src/video/095_video_context_menu.js | 59 +-- .../xmodule/xmodule/js/src/video/09_bumper.js | 4 +- .../js/src/video/09_events_bumper_plugin.js | 8 +- .../xmodule/js/src/video/09_events_plugin.js | 14 +- .../js/src/video/09_play_pause_control.js | 6 +- .../js/src/video/09_play_placeholder.js | 12 +- .../js/src/video/09_play_skip_control.js | 4 +- .../js/src/video/09_save_state_plugin.js | 8 +- .../xmodule/js/src/video/09_video_caption.js | 62 +-- .../xmodule/xmodule/js/src/video/10_main.js | 3 +- .../common/js/components/utils/view_utils.js | 46 +- .../common/js/components/views/tabbed_view.js | 22 +- common/static/common/js/discussion/content.js | 56 +-- .../static/common/js/discussion/discussion.js | 4 +- .../models/discussion_course_settings.js | 2 +- .../js/discussion/models/discussion_user.js | 2 +- common/static/common/js/discussion/utils.js | 6 +- .../views/discussion_content_view.js | 2 +- .../views/discussion_thread_edit_view.js | 4 +- .../views/discussion_thread_profile_view.js | 2 +- .../views/discussion_thread_show_view.js | 2 +- .../views/discussion_thread_view.js | 20 +- .../js/discussion/views/new_post_view.js | 2 +- .../views/response_comment_edit_view.js | 2 +- .../views/response_comment_show_view.js | 2 +- .../discussion/views/response_comment_view.js | 2 +- .../views/thread_response_edit_view.js | 2 +- .../views/thread_response_show_view.js | 2 +- .../discussion/views/thread_response_view.js | 12 +- .../js/spec/components/feedback_spec.js | 16 +- .../js/spec/components/tabbed_view_spec.js | 34 +- .../js/spec/components/view_utils_spec.js | 26 +- .../common/js/spec/discussion/content_spec.js | 12 +- .../view/discussion_thread_edit_view_spec.js | 8 +- .../discussion_thread_profile_view_spec.js | 4 +- .../view/discussion_thread_view_spec.js | 16 +- .../view/discussion_view_spec_helper.js | 4 +- .../view/response_comment_show_view_spec.js | 4 +- .../view/response_comment_view_spec.js | 2 +- .../view/thread_response_show_view_spec.js | 62 +-- .../view/thread_response_view_spec.js | 6 +- .../common/js/spec_helpers/jasmine-stealth.js | 5 +- .../common/js/spec_helpers/page_helpers.js | 4 +- .../js/spec_helpers/template_helpers.js | 4 +- .../common/js/spec_helpers/view_helpers.js | 32 +- common/static/common/js/xblock/core.js | 2 +- common/static/common/js/xblock/runtime.v1.js | 2 +- common/static/js/capa/annotationinput.js | 3 +- .../js/capa/chemical_equation_preview.js | 2 +- common/static/js/capa/choicetextinput.js | 42 +- common/static/js/capa/design-protein-2d.js | 4 +- .../js/capa/drag_and_drop/base_image.js | 18 +- .../js/capa/drag_and_drop/config_parser.js | 16 +- .../js/capa/drag_and_drop/draggable_events.js | 36 +- .../js/capa/drag_and_drop/draggable_logic.js | 70 +-- .../js/capa/drag_and_drop/draggables.js | 142 +++--- common/static/js/capa/drag_and_drop/main.js | 12 +- .../static/js/capa/drag_and_drop/scroller.js | 40 +- common/static/js/capa/drag_and_drop/state.js | 28 +- .../static/js/capa/drag_and_drop/targets.js | 60 +-- .../js/capa/drag_and_drop/update_input.js | 8 +- common/static/js/capa/edit-a-gene.js | 8 +- common/static/js/capa/editamolecule.js | 24 +- common/static/js/capa/schematicinput.js | 6 +- .../spec/formula_equation_preview_spec.js | 12 +- .../js/capa/src/formula_equation_preview.js | 7 +- common/static/js/capa/src/jschannel.js | 27 +- common/static/js/capa/src/jsinput.js | 10 +- .../static/js/spec/CSS3_workarounds_spec.js | 2 +- .../js/spec/accessibility_tools_spec.js | 1 - common/static/js/spec/lang_edx_spec.js | 24 +- common/static/js/spec/logger_spec.js | 18 +- common/static/js/spec/tooltip_manager_spec.js | 8 +- common/static/js/src/accessibility_tools.js | 18 +- common/static/js/src/lang_edx.js | 8 +- common/static/js/src/logger.js | 14 +- common/static/js/src/tooltip_manager.js | 6 +- common/static/js/src/utility.js | 9 +- .../static/discussion/js/discussion_router.js | 1 - .../support/js/spec/models/enrollment_spec.js | 4 +- .../js/spec/views/certificates_spec.js | 54 +-- .../js/spec/views/enrollment_modal_spec.js | 4 +- .../support/js/spec/views/enrollment_spec.js | 1 - .../static/support/js/views/enrollment.js | 6 +- .../support/js/views/enrollment_modal.js | 3 +- .../spec/collections/topic_collection_spec.js | 2 +- .../teams/js/spec/teams_tab_factory_spec.js | 2 +- .../js/spec/views/edit_team_members_spec.js | 13 +- .../teams/js/spec/views/edit_team_spec.js | 2 +- .../js/spec/views/instructor_tools_spec.js | 3 +- .../teams/js/spec/views/team_card_spec.js | 8 +- .../views/team_profile_header_actions_spec.js | 24 +- .../teams/js/spec/views/topic_card_spec.js | 14 +- .../js/spec_helpers/team_spec_helpers.js | 54 +-- .../teams/static/teams/js/views/edit_team.js | 12 +- .../teams/js/views/edit_team_members.js | 25 +- .../static/teams/js/views/instructor_tools.js | 12 +- .../js/views/team_profile_header_actions.js | 14 +- .../teams/static/teams/js/views/team_utils.js | 9 +- .../teams/static/teams/js/views/teams_tab.js | 55 ++- .../static/teams/js/views/topic_teams.js | 14 +- lms/static/js/Markdown.Converter.js | 34 +- lms/static/js/Markdown.Editor.js | 167 +++---- lms/static/js/Markdown.Sanitizer.js | 25 +- .../js/api_admin/views/catalog_preview.js | 4 +- lms/static/js/ccx/schedule.js | 35 +- .../views/certificate_invalidation_view.js | 15 +- .../views/certificate_whitelist.js | 9 +- .../views/certificate_whitelist_editor.js | 16 +- lms/static/js/commerce/credit.js | 12 +- lms/static/js/commerce/views/receipt_view.js | 4 +- lms/static/js/components/card/views/card.js | 6 +- .../js/components/header/models/header.js | 8 +- lms/static/js/course_survey.js | 3 +- lms/static/js/courseware/credit_progress.js | 14 +- .../courseware/toggle_element_visibility.js | 16 +- lms/static/js/dashboard/credit.js | 2 +- lms/static/js/dashboard/donation.js | 15 +- lms/static/js/dashboard/dropdown.js | 16 +- lms/static/js/dashboard/legacy.js | 16 +- lms/static/js/dashboard/track_events.js | 2 +- lms/static/js/discovery/collection.js | 7 +- .../js/discovery/collections/filters.js | 2 +- lms/static/js/discovery/discovery_factory.js | 11 +- lms/static/js/discovery/models/course_card.js | 2 +- .../js/discovery/models/course_discovery.js | 2 +- .../js/discovery/models/facet_option.js | 2 +- lms/static/js/discovery/models/filter.js | 2 +- .../js/discovery/models/search_state.js | 11 +- lms/static/js/discovery/views/course_card.js | 2 +- .../js/discovery/views/courses_listing.js | 2 +- lms/static/js/discovery/views/facet.js | 2 +- lms/static/js/discovery/views/facets.js | 2 +- lms/static/js/discovery/views/filter_bar.js | 2 +- lms/static/js/discovery/views/filter_label.js | 2 +- .../js/discovery/views/refine_sidebar.js | 2 +- lms/static/js/discovery/views/search_form.js | 5 +- lms/static/js/edxnotes/models/note.js | 50 +- lms/static/js/edxnotes/models/tab.js | 14 +- .../js/edxnotes/plugins/accessibility.js | 65 +-- lms/static/js/edxnotes/plugins/events.js | 19 +- lms/static/js/edxnotes/plugins/scroller.js | 14 +- lms/static/js/edxnotes/utils/logger.js | 2 +- lms/static/js/edxnotes/views/note_item.js | 6 +- lms/static/js/edxnotes/views/notes_factory.js | 8 +- .../views/notes_visibility_factory.js | 2 +- lms/static/js/edxnotes/views/search_box.js | 6 +- lms/static/js/edxnotes/views/shim.js | 22 +- lms/static/js/edxnotes/views/tab_item.js | 8 +- lms/static/js/edxnotes/views/tab_panel.js | 8 +- lms/static/js/edxnotes/views/tab_view.js | 2 +- lms/static/js/edxnotes/views/tabs/tags.js | 25 +- lms/static/js/edxnotes/views/tabs_list.js | 4 +- .../js/edxnotes/views/visibility_decorator.js | 3 +- .../views/financial_assistance_form_view.js | 20 +- lms/static/js/footer-edx.js | 4 +- lms/static/js/form.ext.js | 8 +- lms/static/js/groups/views/cohort_editor.js | 5 +- lms/static/js/groups/views/cohort_form.js | 6 +- lms/static/js/groups/views/cohorts.js | 2 +- .../verified_track_settings_notification.js | 11 +- .../js/instructor_dashboard/certificates.js | 10 +- .../instructor_dashboard/cohort_management.js | 2 +- .../js/instructor_dashboard/data_download.js | 1 - .../js/instructor_dashboard/ecommerce.js | 53 +-- .../js/instructor_dashboard/proctoring.js | 6 +- .../views/collection_list_view.js | 14 +- .../views/explore_new_programs_view.js | 10 +- .../views/program_card_view.js | 15 +- .../learner_dashboard/views/sidebar_view.js | 12 +- lms/static/js/logout.js | 2 +- lms/static/js/pdf-analytics.js | 24 +- lms/static/js/pending_tasks.js | 4 +- lms/static/js/shoppingcart/shoppingcart.js | 11 +- lms/static/js/spec/ccx/schedule_spec.js | 44 +- .../js/spec/components/card/card_spec.js | 8 +- .../js/spec/components/header/header_spec.js | 8 +- lms/static/js/spec/dashboard/donation.js | 4 +- .../spec/discovery/discovery_factory_spec.js | 102 ++-- .../discovery/models/course_directory_spec.js | 102 ++-- .../discovery/models/search_state_spec.js | 30 +- .../spec/discovery/views/course_card_spec.js | 30 +- .../discovery/views/courses_listing_spec.js | 30 +- lms/static/js/spec/edxnotes/helpers.js | 14 +- .../js/spec/edxnotes/models/note_spec.js | 14 +- .../edxnotes/plugins/accessibility_spec.js | 14 +- .../edxnotes/plugins/caret_navigation_spec.js | 2 +- .../js/spec/edxnotes/plugins/events_spec.js | 58 +-- .../js/spec/edxnotes/plugins/scroller_spec.js | 6 +- .../js/spec/edxnotes/utils/logger_spec.js | 3 +- .../js/spec/edxnotes/views/note_item_spec.js | 8 +- .../js/spec/edxnotes/views/notes_page_spec.js | 14 +- .../js/spec/edxnotes/views/search_box_spec.js | 18 +- .../js/spec/edxnotes/views/shim_spec.js | 12 +- .../js/spec/edxnotes/views/tab_view_spec.js | 3 +- .../views/tabs/recent_activity_spec.js | 31 +- .../views/tabs/search_results_spec.js | 42 +- .../financial_assistance_form_view_spec.js | 16 +- .../js/spec/groups/views/cohorts_spec.js | 20 +- .../data_download_spec.js | 12 +- lms/static/js/spec/navigation_spec.js | 44 +- .../js/spec/staff_debug_actions_spec.js | 6 +- .../account_settings_factory_spec.js | 20 +- .../account_settings_fields_helpers.js | 12 +- .../spec/student_account/enrollment_spec.js | 2 +- .../spec/student_account/finish_auth_spec.js | 2 +- .../make_payment_step_view_ab_testing_spec.js | 32 +- .../make_payment_step_view_spec.js | 32 +- .../spec/verify_student/reverify_view_spec.js | 2 +- .../verify_student/webcam_photo_view_spec.js | 8 +- lms/static/js/spec/views/fields_helpers.js | 28 +- lms/static/js/spec/views/fields_spec.js | 18 +- .../js/spec/views/file_uploader_spec.js | 14 +- .../js/spec/views/message_banner_spec.js | 4 +- lms/static/js/spec/views/notification_spec.js | 3 +- lms/static/js/split.js | 4 +- lms/static/js/staff_debug_actions.js | 3 +- lms/static/js/sticky_filter.js | 3 +- lms/static/js/student_account/account.js | 6 +- .../js/student_account/views/FormView.js | 438 +++++++++--------- lms/static/js/toggle_login_modal.js | 30 +- lms/static/js/utils/facebook.js | 11 +- lms/static/js/utils/navigation.js | 33 +- .../js/verify_student/incourse_reverify.js | 10 +- .../models/verification_model.js | 2 +- .../js/verify_student/pay_and_verify.js | 90 ++-- lms/static/js/verify_student/reverify.js | 18 +- .../enrollment_confirmation_step_view.js | 2 +- .../js/verify_student/views/error_view.js | 5 +- .../views/face_photo_step_view.js | 2 +- .../views/id_photo_step_view.js | 2 +- .../verify_student/views/image_input_view.js | 2 +- .../views/incourse_reverify_view.js | 2 +- .../verify_student/views/intro_step_view.js | 2 +- .../views/make_payment_step_view.js | 31 +- .../views/pay_and_verify_view.js | 12 +- .../views/payment_confirmation_step_view.js | 2 +- .../views/reverify_success_step_view.js | 2 +- .../js/verify_student/views/reverify_view.js | 12 +- .../views/review_photos_step_view.js | 2 +- .../js/verify_student/views/step_view.js | 2 +- .../verify_student/views/webcam_photo_view.js | 10 +- lms/static/js/views/fields.js | 38 +- lms/static/js/views/file_uploader.js | 15 +- lms/static/js/wiki/accessible.js | 4 +- lms/static/lms/js/build.js | 16 +- .../lms/js/spec/main_requirejs_coffee.js | 6 +- lms/static/lms/js/xblock/lms.runtime.v1.js | 2 +- .../js/views/dashboard_search_results_view.js | 2 +- scripts/delete-mongo-test-dbs.js | 4 +- scripts/tests/templates/test.js | 6 +- 415 files changed, 3554 insertions(+), 3728 deletions(-) diff --git a/cms/static/cms/js/build.js b/cms/static/cms/js/build.js index 7157989f62..a88009f2b3 100644 --- a/cms/static/cms/js/build.js +++ b/cms/static/cms/js/build.js @@ -100,7 +100,7 @@ * inlined in the build config. */ shim: { - 'xmodule': { + xmodule: { deps: [ 'jquery', 'underscore', 'codemirror', 'tinymce', 'jquery.tinymce', 'jquery.qtip', 'jquery.scrollTo', 'jquery.flot', diff --git a/cms/static/cms/js/main.js b/cms/static/cms/js/main.js index 6474659c36..c2570289b0 100644 --- a/cms/static/cms/js/main.js +++ b/cms/static/cms/js/main.js @@ -43,8 +43,8 @@ message = JSON.parse(jqXHR.responseText).error; } msg = new NotificationView.Error({ - 'title': gettext("Studio's having trouble saving your work"), - 'message': message + title: gettext("Studio's having trouble saving your work"), + message: message }); console.log('Studio AJAX Error', { // eslint-disable-line no-console url: event.currentTarget.URL, diff --git a/cms/static/cms/js/xblock/cms.runtime.v1.js b/cms/static/cms/js/xblock/cms.runtime.v1.js index 6b07ec80e1..ce362ba584 100644 --- a/cms/static/cms/js/xblock/cms.runtime.v1.js +++ b/cms/static/cms/js/xblock/cms.runtime.v1.js @@ -1,5 +1,5 @@ define(['jquery', 'backbone', 'xblock/runtime.v1', 'URI', 'gettext', 'js/utils/modal', - 'common/js/components/views/feedback_notification'], + 'common/js/components/views/feedback_notification'], function($, Backbone, XBlock, URI, gettext, ModalUtils, NotificationView) { 'use strict'; @@ -149,7 +149,7 @@ define(['jquery', 'backbone', 'xblock/runtime.v1', 'URI', 'gettext', 'js/utils/m }; return v1; - })(XBlock.Runtime.v1); + }(XBlock.Runtime.v1)); PreviewRuntime.v1 = (function(_super) { __extends(v1, _super); @@ -161,7 +161,7 @@ define(['jquery', 'backbone', 'xblock/runtime.v1', 'URI', 'gettext', 'js/utils/m v1.prototype.handlerPrefix = '/preview/xblock'; return v1; - })(BaseRuntime.v1); + }(BaseRuntime.v1)); StudioRuntime.v1 = (function(_super) { __extends(v1, _super); @@ -173,7 +173,7 @@ define(['jquery', 'backbone', 'xblock/runtime.v1', 'URI', 'gettext', 'js/utils/m v1.prototype.handlerPrefix = '/xblock'; return v1; - })(BaseRuntime.v1); + }(BaseRuntime.v1)); // Install the runtime's into the global namespace window.BaseRuntime = BaseRuntime; diff --git a/cms/static/js/base.js b/cms/static/js/base.js index ed2c75f7bf..0e1bcc8724 100644 --- a/cms/static/js/base.js +++ b/cms/static/js/base.js @@ -25,8 +25,7 @@ require([ ModuleUtils, IframeUtils, DropdownMenuView - ) -{ + ) { var $body; domReady(function() { diff --git a/cms/static/js/certificates/collections/certificates.js b/cms/static/js/certificates/collections/certificates.js index e567514d21..d6ae6c6320 100644 --- a/cms/static/js/certificates/collections/certificates.js +++ b/cms/static/js/certificates/collections/certificates.js @@ -31,8 +31,7 @@ function(Backbone, gettext, Certificate) { // otherwise return empty array if (typeof certificate_info === 'object') { return_array = certificate_info; - } - else { + } else { console.error( interpolate( gettext('Could not parse certificate JSON. %(message)s'), {message: ex.message}, true diff --git a/cms/static/js/certificates/spec/custom_matchers.js b/cms/static/js/certificates/spec/custom_matchers.js index cd960f469f..8079de4883 100644 --- a/cms/static/js/certificates/spec/custom_matchers.js +++ b/cms/static/js/certificates/spec/custom_matchers.js @@ -11,7 +11,7 @@ define(['jquery'], function($) { // eslint-disable-line no-unused-vars compare: function(actual, values) { var passed = _.every(values, function(value, key) { return actual.get(key) === value; - }.bind(this)); + }); return { pass: passed diff --git a/cms/static/js/certificates/spec/views/certificate_details_spec.js b/cms/static/js/certificates/spec/views/certificate_details_spec.js index 4a58c5d97e..7a0332bda8 100644 --- a/cms/static/js/certificates/spec/views/certificate_details_spec.js +++ b/cms/static/js/certificates/spec/views/certificate_details_spec.js @@ -131,8 +131,8 @@ function(_, Course, CertificatesCollection, CertificateModel, CertificateDetails it('should parse a JSON object collection into a Backbone model collection', function() { var course_title = 'Test certificate course title override 2'; var CERTIFICATE_JSON_OBJECT = [{ - 'course_title': course_title, - 'signatories': '[]' + course_title: course_title, + signatories: '[]' }]; this.collection.parse(CERTIFICATE_JSON_OBJECT); var model = this.collection.at(1); diff --git a/cms/static/js/certificates/views/certificate_details.js b/cms/static/js/certificates/views/certificate_details.js index a23ad8be06..7972dc74ba 100644 --- a/cms/static/js/certificates/views/certificate_details.js +++ b/cms/static/js/certificates/views/certificate_details.js @@ -49,8 +49,7 @@ function($, _, str, gettext, BaseView, SignatoryModel, SignatoryDetailsView, Vie return self.model.set('editing', true); } ); - } - else { + } else { this.model.set('editing', true); } }, diff --git a/cms/static/js/certificates/views/certificate_editor.js b/cms/static/js/certificates/views/certificate_editor.js index 82a3291ef9..e08ac582b4 100644 --- a/cms/static/js/certificates/views/certificate_editor.js +++ b/cms/static/js/certificates/views/certificate_editor.js @@ -25,7 +25,7 @@ function($, _, Backbone, gettext, 'change .certificate-course-title-input': 'setCourseTitle', 'focus .input-text': 'onFocus', 'blur .input-text': 'onBlur', - 'submit': 'setAndClose', + submit: 'setAndClose', 'click .action-cancel': 'cancel', 'click .action-add-signatory': 'addSignatory' }, diff --git a/cms/static/js/certificates/views/certificate_item.js b/cms/static/js/certificates/views/certificate_item.js index 11aeed55c8..ed9cc9fd29 100644 --- a/cms/static/js/certificates/views/certificate_item.js +++ b/cms/static/js/certificates/views/certificate_item.js @@ -23,8 +23,8 @@ function(gettext, ListItemView, CertificateDetailsView, CertificateEditorView) { attributes: function() { // Retrieves the defined attribute set return { - 'id': this.model.get('id'), - 'tabindex': -1 + id: this.model.get('id'), + tabindex: -1 }; }, diff --git a/cms/static/js/certificates/views/signatory_details.js b/cms/static/js/certificates/views/signatory_details.js index 596e294861..9d6543e279 100644 --- a/cms/static/js/certificates/views/signatory_details.js +++ b/cms/static/js/certificates/views/signatory_details.js @@ -76,10 +76,10 @@ function($, _, str, Backbone, gettext, TemplateUtils, ViewUtils, BaseView, Signa actionableModel.setOriginalAttributes(); dfd.resolve(); self.closeSignatoryEditView(); - }.bind(this) + } }); return dfd; - }.bind(this)); + }); }, closeSignatoryEditView: function(event) { diff --git a/cms/static/js/certificates/views/signatory_editor.js b/cms/static/js/certificates/views/signatory_editor.js index c6be7ba4f1..21d53f7f20 100644 --- a/cms/static/js/certificates/views/signatory_editor.js +++ b/cms/static/js/certificates/views/signatory_editor.js @@ -144,8 +144,7 @@ function($, _, Backbone, gettext, if (model.isNew()) { model.collection.remove(model); self.eventAgg.trigger('onSignatoryRemoved', model); - } - else { + } else { deleting.show(); model.destroy({ wait: true, @@ -200,8 +199,7 @@ function($, _, Backbone, gettext, $(selector).addClass('error'); $(selector).append("" + errorMessage + ''); } - } - else { + } else { // Remove the error message. $(selector).removeClass('error'); $(selector + '>span.message-error').remove(); diff --git a/cms/static/js/factories/base.js b/cms/static/js/factories/base.js index ac5a706c62..abaeb89d17 100644 --- a/cms/static/js/factories/base.js +++ b/cms/static/js/factories/base.js @@ -1,2 +1,2 @@ define(['js/base', 'cms/js/main', 'js/src/logger', 'datepair', 'accessibility', -'ieshim', 'tooltip_manager', 'lang_edx', 'js/models/course']); + 'ieshim', 'tooltip_manager', 'lang_edx', 'js/models/course']); diff --git a/cms/static/js/factories/login.js b/cms/static/js/factories/login.js index 3b01d4e477..7d080cdb2b 100644 --- a/cms/static/js/factories/login.js +++ b/cms/static/js/factories/login.js @@ -22,10 +22,10 @@ define(['jquery.cookie', 'utility', 'common/js/components/utils/view_utils'], fu $('form#login_form').submit(function(event) { event.preventDefault(); - var submitButton = $('#submit'), + var $submitButton = $('#submit'), deferred = new $.Deferred(), promise = deferred.promise(); - ViewUtils.disableElementWhileRunning(submitButton, function() { return promise; }); + ViewUtils.disableElementWhileRunning($submitButton, function() { return promise; }); var submit_data = $('#login_form').serialize(); postJSON('/login_post', submit_data, function(json) { diff --git a/cms/static/js/factories/manage_users.js b/cms/static/js/factories/manage_users.js index 1db6d11c68..837ea6fec7 100644 --- a/cms/static/js/factories/manage_users.js +++ b/cms/static/js/factories/manage_users.js @@ -16,7 +16,7 @@ function(_, gettext, ManageUsersAndRoles) { // Roles order are important: first role is considered initial role (the role added to user when (s)he's added // Last role is considered an admin role (unrestricted access + ability to manage other users' permissions) // Changing roles is performed in promote-demote fashion, so moves only to adjacent roles is allowed - var roles = [{key: 'staff', name: gettext('Staff')}, {key: 'instructor', 'name': gettext('Admin')}]; + var roles = [{key: 'staff', name: gettext('Staff')}, {key: 'instructor', name: gettext('Admin')}]; var options = { el: $('#content'), diff --git a/cms/static/js/factories/manage_users_lib.js b/cms/static/js/factories/manage_users_lib.js index 504ca9e3f3..8bfe07134d 100644 --- a/cms/static/js/factories/manage_users_lib.js +++ b/cms/static/js/factories/manage_users_lib.js @@ -19,7 +19,7 @@ function(_, gettext, ManageUsersAndRoles) { var roles = [ {key: 'library_user', name: gettext('Library User')}, {key: 'staff', name: gettext('Staff')}, - {key: 'instructor', 'name': gettext('Admin')} + {key: 'instructor', name: gettext('Admin')} ]; var options = { diff --git a/cms/static/js/factories/settings_advanced.js b/cms/static/js/factories/settings_advanced.js index 37fad0b6c1..16eb86f45e 100644 --- a/cms/static/js/factories/settings_advanced.js +++ b/cms/static/js/factories/settings_advanced.js @@ -24,17 +24,16 @@ define([ editor.render(); $('#deprecated-settings').click(function() { - var wrapperDeprecatedSetting = $('.wrapper-deprecated-setting'), - deprecatedSettingsLabel = $('.deprecated-settings-label'); + var $wrapperDeprecatedSetting = $('.wrapper-deprecated-setting'), + $deprecatedSettingsLabel = $('.deprecated-settings-label'); if ($(this).is(':checked')) { - wrapperDeprecatedSetting.addClass('is-set'); - deprecatedSettingsLabel.text(gettext('Hide Deprecated Settings')); + $wrapperDeprecatedSetting.addClass('is-set'); + $deprecatedSettingsLabel.text(gettext('Hide Deprecated Settings')); editor.render_deprecated = true; - } - else { - wrapperDeprecatedSetting.removeClass('is-set'); - deprecatedSettingsLabel.text(gettext('Show Deprecated Settings')); + } else { + $wrapperDeprecatedSetting.removeClass('is-set'); + $deprecatedSettingsLabel.text(gettext('Show Deprecated Settings')); editor.render_deprecated = false; } diff --git a/cms/static/js/models/course.js b/cms/static/js/models/course.js index 95a77454f4..090ca9aee9 100644 --- a/cms/static/js/models/course.js +++ b/cms/static/js/models/course.js @@ -1,7 +1,7 @@ define(['backbone'], function(Backbone) { var Course = Backbone.Model.extend({ defaults: { - 'name': '' + name: '' }, validate: function(attrs, options) { if (!attrs.name) { diff --git a/cms/static/js/models/course_info.js b/cms/static/js/models/course_info.js index fbf114d795..3f32dcf492 100644 --- a/cms/static/js/models/course_info.js +++ b/cms/static/js/models/course_info.js @@ -5,8 +5,8 @@ define(['backbone'], function(Backbone) { url: '', defaults: { - 'updates': null, // UpdateCollection - 'handouts': null // HandoutCollection + updates: null, // UpdateCollection + handouts: null // HandoutCollection } }); return CourseInfo; diff --git a/cms/static/js/models/course_update.js b/cms/static/js/models/course_update.js index 33ffca2eb7..9bd642aad6 100644 --- a/cms/static/js/models/course_update.js +++ b/cms/static/js/models/course_update.js @@ -2,16 +2,16 @@ define(['backbone', 'jquery', 'jquery.ui'], function(Backbone, $) { // course update -- biggest kludge here is the lack of a real id to map updates to originals var CourseUpdate = Backbone.Model.extend({ defaults: { - 'date': $.datepicker.formatDate('MM d, yy', new Date()), - 'content': '', - 'push_notification_enabled': false, - 'push_notification_selected': false + date: $.datepicker.formatDate('MM d, yy', new Date()), + content: '', + push_notification_enabled: false, + push_notification_selected: false }, validate: function(attrs) { var date_exists = (attrs.date !== null && attrs.date !== ''); var date_is_valid_string = ($.datepicker.formatDate('MM d, yy', new Date(attrs.date)) === attrs.date); if (!(date_exists && date_is_valid_string)) { - return {'date_required': gettext('Action required: Enter a valid date.')}; + return {date_required: gettext('Action required: Enter a valid date.')}; } } }); diff --git a/cms/static/js/models/explicit_url.js b/cms/static/js/models/explicit_url.js index fa1cad1afa..3ee510074f 100644 --- a/cms/static/js/models/explicit_url.js +++ b/cms/static/js/models/explicit_url.js @@ -5,7 +5,7 @@ define(['backbone'], function(Backbone) { return Backbone.Model.extend({ defaults: { - 'explicit_url': '' + explicit_url: '' }, url: function() { return this.get('explicit_url'); diff --git a/cms/static/js/models/license.js b/cms/static/js/models/license.js index 9ba433d4d8..ff90c60b8d 100644 --- a/cms/static/js/models/license.js +++ b/cms/static/js/models/license.js @@ -1,9 +1,9 @@ define(['backbone', 'underscore'], function(Backbone, _) { var LicenseModel = Backbone.Model.extend({ defaults: { - 'type': null, - 'options': {}, - 'custom': false // either `false`, or a string + type: null, + options: {}, + custom: false // either `false`, or a string }, initialize: function(attributes) { @@ -55,16 +55,16 @@ define(['backbone', 'underscore'], function(Backbone, _) { if (spaceIndex == -1) { // if there's no space, it's a license type without options return this.set({ - 'type': string, - 'options': {}, - 'custom': false + type: string, + options: {}, + custom: false }, options); } else { // if there is a space, it's a custom license return this.set({ - 'type': null, - 'options': {}, - 'custom': string + type: null, + options: {}, + custom: string }, options); } } @@ -91,7 +91,7 @@ define(['backbone', 'underscore'], function(Backbone, _) { }); return this.set({ - 'type': type, 'options': optionsObj, 'custom': false + type: type, options: optionsObj, custom: false }, options); } }); diff --git a/cms/static/js/models/location.js b/cms/static/js/models/location.js index 42d40ed228..e755fb6fef 100644 --- a/cms/static/js/models/location.js +++ b/cms/static/js/models/location.js @@ -9,11 +9,11 @@ define(['backbone', 'underscore'], function(Backbone, _) { }, toUrl: function(overrides) { return; - (overrides && overrides['tag'] ? overrides['tag'] : this.get('tag')) + '://' + - (overrides && overrides['org'] ? overrides['org'] : this.get('org')) + '/' + - (overrides && overrides['course'] ? overrides['course'] : this.get('course')) + '/' + - (overrides && overrides['category'] ? overrides['category'] : this.get('category')) + '/' + - (overrides && overrides['name'] ? overrides['name'] : this.get('name')) + '/'; + (overrides && overrides.tag ? overrides.tag : this.get('tag')) + '://' + + (overrides && overrides.org ? overrides.org : this.get('org')) + '/' + + (overrides && overrides.course ? overrides.course : this.get('course')) + '/' + + (overrides && overrides.category ? overrides.category : this.get('category')) + '/' + + (overrides && overrides.name ? overrides.name : this.get('name')) + '/'; }, _tagPattern: /[^:]+/g, _fieldPattern: new RegExp('[^/]+', 'g'), @@ -27,8 +27,7 @@ define(['backbone', 'underscore'], function(Backbone, _) { category: payload[3], name: payload[4] }; - } - else if (_.isString(payload)) { + } else if (_.isString(payload)) { this._tagPattern.lastIndex = 0; // odd regex behavior requires this to be reset sometimes var foundTag = this._tagPattern.exec(payload); if (foundTag) { @@ -40,18 +39,15 @@ define(['backbone', 'underscore'], function(Backbone, _) { category: this.getNextField(payload), name: this.getNextField(payload) }; - } - else return null; - } - else { + } else return null; + } else { return payload; } }, getNextField: function(payload) { try { return this._fieldPattern.exec(payload)[0]; - } - catch (err) { + } catch (err) { return ''; } } diff --git a/cms/static/js/models/metadata.js b/cms/static/js/models/metadata.js index efa6333b4f..1372861005 100644 --- a/cms/static/js/models/metadata.js +++ b/cms/static/js/models/metadata.js @@ -5,13 +5,13 @@ define(['backbone'], function(Backbone) { */ var Metadata = Backbone.Model.extend({ defaults: { - 'field_name': null, - 'display_name': null, - 'value': null, - 'explicitly_set': null, - 'default_value': null, - 'options': null, - 'type': null + field_name: null, + display_name: null, + value: null, + explicitly_set: null, + default_value: null, + options: null, + type: null }, initialize: function() { diff --git a/cms/static/js/models/module_info.js b/cms/static/js/models/module_info.js index cfb4e44b5f..32c1291b12 100644 --- a/cms/static/js/models/module_info.js +++ b/cms/static/js/models/module_info.js @@ -3,10 +3,10 @@ define(['backbone', 'js/utils/module'], function(Backbone, ModuleUtils) { urlRoot: ModuleUtils.urlRoot, defaults: { - 'id': null, - 'data': null, - 'metadata': null, - 'children': null + id: null, + data: null, + metadata: null, + children: null } }); return ModuleInfo; diff --git a/cms/static/js/models/section.js b/cms/static/js/models/section.js index 8ee969da64..2499ac8ddf 100644 --- a/cms/static/js/models/section.js +++ b/cms/static/js/models/section.js @@ -2,7 +2,7 @@ define(['backbone', 'gettext', 'common/js/components/views/feedback_notification function(Backbone, gettext, NotificationView, ModuleUtils) { var Section = Backbone.Model.extend({ defaults: { - 'name': '' + name: '' }, validate: function(attrs, options) { if (!attrs.name) { diff --git a/cms/static/js/models/settings/course_details.js b/cms/static/js/models/settings/course_details.js index 1498a6be13..394883d480 100644 --- a/cms/static/js/models/settings/course_details.js +++ b/cms/static/js/models/settings/course_details.js @@ -90,7 +90,7 @@ define(['backbone', 'underscore', 'gettext', 'js/models/validation_helpers', 'js set_videosource: function(newsource) { // newsource either is