Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UX-1642 Making visual tweaks and enhancements to the logistration form

Browse Source
This commit is contained in:
Chris Rodriguez
2015-02-25 12:31:35 -05:00
parent 3d520f4fa8
commit 5ae7cc7ee1
8 changed files with 132 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
openedx/core/djangoapps/user_api/tests/test_views.py
View File

@@ -785,6 +785,8 @@ class PasswordResetViewTest(ApiTestCase):
class RegistrationViewTest(ApiTestCase):
"""Tests for the registration end-points of the User API. """
maxDiff = None
USERNAME = "bob"
EMAIL = "bob@example.com"
PASSWORD = "password"
@@ -843,9 +845,10 @@ class RegistrationViewTest(ApiTestCase):
u"type": u"text",
u"required": True,
u"label": u"Full name",
u"instructions": u"The name that will appear on your certificates",
u"placeholder": u"Jane Doe",
u"instructions": u"Needed for any certificates you may earn",
u"restrictions": {
"max_length": NAME_MAX_LENGTH,
"max_length": 255
},
}
)
@@ -857,7 +860,8 @@ class RegistrationViewTest(ApiTestCase):
u"type": u"text",
u"required": True,
u"label": u"Public username",
u"instructions": u"The name that will identify you in your courses",
u"placeholder": u"JaneDoe",
u"instructions": u"The name that will identify you in your courses - <strong>(cannot be changed later)</strong>",
u"restrictions": {
"min_length": USERNAME_MIN_LENGTH,
"max_length": USERNAME_MAX_LENGTH
@@ -868,13 +872,14 @@ class RegistrationViewTest(ApiTestCase):
self._assert_reg_field(
no_extra_fields_setting,
{
u"placeholder": "",
u"name": u"password",
u"type": u"password",
u"required": True,
u"label": u"Password",
u"restrictions": {
"min_length": PASSWORD_MIN_LENGTH,
"max_length": PASSWORD_MAX_LENGTH
'min_length': account_api.PASSWORD_MIN_LENGTH,
'max_length': account_api.PASSWORD_MAX_LENGTH
},
}
)
@@ -923,7 +928,8 @@ class RegistrationViewTest(ApiTestCase):
u"type": u"text",
u"required": True,
u"label": u"Full name",
u"instructions": u"The name that will appear on your certificates",
u"placeholder": u"Jane Doe",
u"instructions": u"Needed for any certificates you may earn",
u"restrictions": {
"max_length": NAME_MAX_LENGTH,
}
@@ -939,8 +945,8 @@ class RegistrationViewTest(ApiTestCase):
u"type": u"text",
u"required": True,
u"label": u"Public username",
u"placeholder": u"",
u"instructions": u"The name that will identify you in your courses",
u"placeholder": u"JaneDoe",
u"instructions": u"The name that will identify you in your courses - <strong>(cannot be changed later)</strong>",
u"restrictions": {
"min_length": USERNAME_MIN_LENGTH,
"max_length": USERNAME_MAX_LENGTH
@@ -1511,7 +1517,28 @@ class RegistrationViewTest(ApiTestCase):
# Verify that the form description matches what we'd expect
form_desc = json.loads(response.content)
self.assertIn(expected_field, form_desc["fields"])
# Search the form for this field
actual_field = None
for field in form_desc["fields"]:
if field["name"] == expected_field["name"]:
actual_field = field
break
self.assertIsNot(
actual_field, None,
msg="Could not find field {name}".format(name=expected_field["name"])
)
for key, value in expected_field.iteritems():
self.assertEqual(
expected_field[key], actual_field[key],
msg=u"Expected {expected} for {key} but got {actual} instead".format(
key=key,
expected=expected_field[key],
actual=actual_field[key]
)
)
@ddt.ddt

14
openedx/core/djangoapps/user_api/views.py
View File

@@ -346,13 +346,18 @@ class RegistrationView(APIView):
# meant to hold the user's full name.
name_label = _(u"Full name")
# Translators: This example name is used as a placeholder in
# a field on the registration form meant to hold the user's name.
name_placeholder = _(u"Jane Doe")
# Translators: These instructions appear on the registration form, immediately
# below a field meant to hold the user's full name.
name_instructions = _(u"The name that will appear on your certificates")
name_instructions = _(u"Needed for any certificates you may earn")
form_desc.add_field(
"name",
label=name_label,
placeholder=name_placeholder,
instructions=name_instructions,
restrictions={
"max_length": NAME_MAX_LENGTH,
@@ -377,13 +382,18 @@ class RegistrationView(APIView):
# Translators: These instructions appear on the registration form, immediately
# below a field meant to hold the user's public username.
username_instructions = _(
u"The name that will identify you in your courses"
u"The name that will identify you in your courses - {bold_start}(cannot be changed later){bold_end}").format(bold_start=u'<strong>', bold_end=u'</strong>'
)
# Translators: This example username is used as a placeholder in
# a field on the registration form meant to hold the user's username.
username_placeholder = _(u"JaneDoe")
form_desc.add_field(
"username",
label=username_label,
instructions=username_instructions,
placeholder=username_placeholder,
restrictions={
"min_length": USERNAME_MIN_LENGTH,
"max_length": USERNAME_MAX_LENGTH,