From a6616fd29206fcea8df6ac7e075266e0266fd610 Mon Sep 17 00:00:00 2001 From: sarina Date: Thu, 2 Sep 2021 13:15:38 -0400 Subject: [PATCH] fix: Remove or contextualize refs to edX.org in strings --- lms/djangoapps/branding/api.py | 2 ++ .../bulk_email/tests/test_course_optout.py | 2 +- lms/templates/bulk_email/unsubscribe_success.html | 6 ++++-- .../financial-assistance/financial-assistance.html | 12 ++++++++++++ .../edx_ace/recurringnudge_day3/email/body.txt | 4 ++-- 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/lms/djangoapps/branding/api.py b/lms/djangoapps/branding/api.py index 36d6bbc534..b311873917 100644 --- a/lms/djangoapps/branding/api.py +++ b/lms/djangoapps/branding/api.py @@ -112,6 +112,8 @@ def get_footer(is_secure=True, language=settings.LANGUAGE_CODE): "&utm_source=opensource-partner" "&utm_content=open-edx-partner-footer-link" "&utm_campaign=open-edx-footer", + # Translators: This string is used across Open edX installations + # as a callback to edX. Please do not translate `edX.org` "text": _("Take free online courses at edX.org"), }, } diff --git a/lms/djangoapps/bulk_email/tests/test_course_optout.py b/lms/djangoapps/bulk_email/tests/test_course_optout.py index df0dd9b097..e8d9ed113d 100644 --- a/lms/djangoapps/bulk_email/tests/test_course_optout.py +++ b/lms/djangoapps/bulk_email/tests/test_course_optout.py @@ -88,7 +88,7 @@ class TestOptoutCourseEmails(ModuleStoreTestCase): def test_optout_using_unsubscribe_link_in_email(self): """ - Make sure email is't sent to learner after opt out. + Make sure email isn't sent to learner after opt out. """ self.client.logout() diff --git a/lms/templates/bulk_email/unsubscribe_success.html b/lms/templates/bulk_email/unsubscribe_success.html index 6c77df6236..53e3e51a91 100644 --- a/lms/templates/bulk_email/unsubscribe_success.html +++ b/lms/templates/bulk_email/unsubscribe_success.html @@ -1,6 +1,7 @@ <%page expression_filter="h"/> <%! from openedx.core.djangolib.markup import HTML, Text +from django.conf import settings from django.utils.translation import ugettext as _ %> @@ -34,8 +35,9 @@ from django.utils.translation import ugettext as _ %endif

- ${Text(_("{link_start}Return to edX.org{link_end}")).format( - link_start=HTML(" "), + ${Text(_("{link_start}Return to {platform_name}{link_end}")).format( + link_start=HTML(" ").format(lms_route_url=settings.LMS_ROOT_URL), + platform_name=settings.PLATFORM_NAME, link_end=HTML(" "), )} diff --git a/lms/templates/financial-assistance/financial-assistance.html b/lms/templates/financial-assistance/financial-assistance.html index 4321b6e453..9389af9185 100644 --- a/lms/templates/financial-assistance/financial-assistance.html +++ b/lms/templates/financial-assistance/financial-assistance.html @@ -18,12 +18,24 @@ from common.djangoapps.edxmako.shortcuts import marketing_link

${_("A Note to Learners")}

+ ## Translators: This string will not be used in Open edX installations.

${_("Dear edX Learner,")}

+ + ## Translators: This string will not be used in Open edX installations.

${_("EdX Financial Assistance is a program we created to give learners in all financial circumstances a chance to earn a Verified Certificate upon successful completion of an edX course.")}

+ + ## Translators: This string will not be used in Open edX installations.

${_("If you are interested in working toward a Verified Certificate, but cannot afford to pay the fee, please apply now. Please note that financial assistance is limited and may not be awarded to all eligible candidates.")}

+ + ## Translators: This string will not be used in Open edX installations.

${_("In order to be eligible for edX Financial Assistance, you must demonstrate that paying the Verified Certificate fee would cause you economic hardship. To apply, you will be asked to answer a few questions about why you are applying and how the Verified Certificate will benefit you.")}

+ + ## Translators: This string will not be used in Open edX installations.

${_("If your application is approved, we'll give you instructions for verifying your identity on edx.org so you can start working toward completing your edX course.")}

+ + ## Translators: This string will not be used in Open edX installations.

${_("EdX is committed to making it possible for you to take high quality courses from leading institutions regardless of your financial situation, earn a Verified Certificate, and share your success with others.")}

+ ## Translators: This string will not be used in Open edX installations. Do not translate the name "Anant".

${_("Sincerely, Anant")}

diff --git a/themes/red-theme/lms/templates/schedules/edx_ace/recurringnudge_day3/email/body.txt b/themes/red-theme/lms/templates/schedules/edx_ace/recurringnudge_day3/email/body.txt index 3354bbdaae..410d92c2b9 100644 --- a/themes/red-theme/lms/templates/schedules/edx_ace/recurringnudge_day3/email/body.txt +++ b/themes/red-theme/lms/templates/schedules/edx_ace/recurringnudge_day3/email/body.txt @@ -4,14 +4,14 @@ This is the RED theme! {% if course_ids|length > 1 %} {% blocktrans trimmed %} - Remember when you enrolled in {{ course_name }}, and other courses on edX.org? We do, and we’re glad + Remember when you enrolled in {{ course_name }}, and other courses on {{ platform_name }}? We do, and we’re glad to have you! Come see what everyone is learning. {% endblocktrans %} {% trans "Start learning now" %} <{% with_link_tracking dashboard_url %}> {% else %} {% blocktrans trimmed %} - Remember when you enrolled in {{ course_name }} on edX.org? We do, and we’re glad + Remember when you enrolled in {{ course_name }} on {{ platform_name }}? We do, and we’re glad to have you! Come see what everyone is learning. {% endblocktrans %}