From a501fbfc2dc656115c298e36c28ecd02f92dea4e Mon Sep 17 00:00:00 2001 From: Louis Pilfold Date: Mon, 13 Oct 2014 14:43:16 +0100 Subject: [PATCH 1/3] Stop page extending out of viewport width by 40px Currently the .container and .wrapper-footer elements are set to 100%, and also have horizontal padding added to them. This results in a total width of greater than the full width of the viewport; This causing the browser to scroll horizonally into empty space, regardless of how wide the viewport is. I had added the `box-sizing: border-box` to these elements in order to resolve this. Cheers, Louis --- lms/static/sass/base/_base.scss | 1 + lms/static/sass/shared/_footer.scss | 1 + 2 files changed, 2 insertions(+) diff --git a/lms/static/sass/base/_base.scss b/lms/static/sass/base/_base.scss index a382a3a770..31d5a98dd2 100644 --- a/lms/static/sass/base/_base.scss +++ b/lms/static/sass/base/_base.scss @@ -107,6 +107,7 @@ a:focus { .container { @include clearfix; + box-sizing: border-box; margin: 0 auto 0; padding: 0px 30px; max-width: grid-width(12); diff --git a/lms/static/sass/shared/_footer.scss b/lms/static/sass/shared/_footer.scss index 8a7717c825..ed60aed00b 100644 --- a/lms/static/sass/shared/_footer.scss +++ b/lms/static/sass/shared/_footer.scss @@ -8,6 +8,7 @@ footer { @include clearfix(); + box-sizing: border-box; max-width: grid-width(12); min-width: 760px; width: flex-grid(12); From 01d9a6de10219e216c55961b18dd282c729bf104 Mon Sep 17 00:00:00 2001 From: Louis Pilfold Date: Mon, 13 Oct 2014 15:01:00 +0100 Subject: [PATCH 2/3] Add Louis Pilfold to AUTHORS --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 0c98a82021..e37dd7e395 100644 --- a/AUTHORS +++ b/AUTHORS @@ -178,3 +178,4 @@ Paul Medlock-Walton Henry Tareque Eugeny Kolpakov Omar Al-Ithawi +Louis Pilfold From 16ed49749742b60c98bc20836dbb34b46fe9282e Mon Sep 17 00:00:00 2001 From: Louis Pilfold Date: Fri, 17 Oct 2014 09:09:19 +0100 Subject: [PATCH 3/3] Use box-sizing SCSS mixin rather than property --- lms/static/sass/base/_base.scss | 2 +- lms/static/sass/shared/_footer.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lms/static/sass/base/_base.scss b/lms/static/sass/base/_base.scss index 31d5a98dd2..8f6cfe98a6 100644 --- a/lms/static/sass/base/_base.scss +++ b/lms/static/sass/base/_base.scss @@ -107,7 +107,7 @@ a:focus { .container { @include clearfix; - box-sizing: border-box; + @include box-sizing(border-box); margin: 0 auto 0; padding: 0px 30px; max-width: grid-width(12); diff --git a/lms/static/sass/shared/_footer.scss b/lms/static/sass/shared/_footer.scss index ed60aed00b..c2b2bafa9a 100644 --- a/lms/static/sass/shared/_footer.scss +++ b/lms/static/sass/shared/_footer.scss @@ -8,7 +8,7 @@ footer { @include clearfix(); - box-sizing: border-box; + @include box-sizing(border-box); max-width: grid-width(12); min-width: 760px; width: flex-grid(12);