Andal.LND/edx-platform
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: fix is_safe_url and urlquote warnings (#33041)

Browse Source 
* fix: fix is_safe_url and urlquote warnings
* fix: replace urlquote with quote
This commit is contained in:
Usama Sadiq
2023-08-17 16:59:23 +05:00
committed by GitHub
parent f20b7ec985
commit 59782fa625
7 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
openedx/core/djangoapps/user_authn/tests/test_utils.py
View File

@@ -41,7 +41,7 @@ class TestRedirectUtils(TestCase):
RedirectCase('http://edx.org/courses', 'edx.org', req_is_secure=False, expected_is_safe=True),
RedirectCase('http://edx.org/courses', 'edx.org', req_is_secure=True, expected_is_safe=False),
# Django's is_safe_url protects against "///"
# Django's url_has_allowed_host_and_scheme protects against "///"
RedirectCase('http:///edx.org/courses', 'edx.org', req_is_secure=True, expected_is_safe=False),
)
@ddt.unpack

4
openedx/core/djangoapps/user_authn/utils.py
View File

@@ -56,11 +56,11 @@ def is_safe_login_or_logout_redirect(redirect_to, request_host, dot_client_id, r
if redirect_to in application.redirect_uris:
login_redirect_whitelist.add(urlparse(redirect_to).netloc)
is_safe_url = http.is_safe_url(
url_has_allowed_host_and_scheme = http.url_has_allowed_host_and_scheme(
redirect_to, allowed_hosts=login_redirect_whitelist, require_https=require_https
)
return is_safe_url
return url_has_allowed_host_and_scheme
def is_registration_api_v1(request):