From 56f00438770390b8d176cc8306abbdb8a7e8fe68 Mon Sep 17 00:00:00 2001 From: Chris Dodge Date: Thu, 3 Sep 2015 09:02:32 -0400 Subject: [PATCH] reduce logging severity from exception to error --- openedx/core/djangoapps/credit/api/eligibility.py | 2 +- openedx/core/djangoapps/credit/models.py | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/openedx/core/djangoapps/credit/api/eligibility.py b/openedx/core/djangoapps/credit/api/eligibility.py index 758617bad5..b83745a5fb 100644 --- a/openedx/core/djangoapps/credit/api/eligibility.py +++ b/openedx/core/djangoapps/credit/api/eligibility.py @@ -320,7 +320,7 @@ def remove_credit_requirement_status(username, course_key, req_namespace, req_na # but that could cause serious performance issues if many users attempt to # lock the row at the same time. # Instead, we skip removing the requirement and log an error. - if req_to_remove is None: + if not req_to_remove: log.error( ( u'Could not remove credit requirement in course "%s" ' diff --git a/openedx/core/djangoapps/credit/models.py b/openedx/core/djangoapps/credit/models.py index b77505daec..1bc67198e6 100644 --- a/openedx/core/djangoapps/credit/models.py +++ b/openedx/core/djangoapps/credit/models.py @@ -482,7 +482,13 @@ class CreditRequirementStatus(TimeStampedModel): requirement_status = cls.objects.get(username=username, requirement=requirement) requirement_status.delete() except cls.DoesNotExist: - log.exception(u'The requirement status does not exist against the username %s.', username) + log_msg = ( + u'The requirement status {requirement} does not exist for username {username}.'.format( + requirement=requirement, + username=username + ) + ) + log.error(log_msg) return