From 569fb36fee5e012407eb3b40e69fd0862a58e98c Mon Sep 17 00:00:00 2001 From: Diane Kaplan Date: Thu, 23 Jul 2020 13:21:05 -0400 Subject: [PATCH] [REV-1205] Add ecommerce event tracking to welcome banner upsell links (#24529) --- lms/templates/courseware/courseware.html | 16 +++++++++++++++- .../access_denied_message.html | 2 +- .../course_experience/course-home-fragment.html | 10 ++++++++-- .../tests/views/test_course_home.py | 2 +- openedx/features/discounts/utils.py | 2 +- 5 files changed, 26 insertions(+), 6 deletions(-) diff --git a/lms/templates/courseware/courseware.html b/lms/templates/courseware/courseware.html index fbaf36d28c..4fde457e41 100644 --- a/lms/templates/courseware/courseware.html +++ b/lms/templates/courseware/courseware.html @@ -275,6 +275,8 @@ ${HTML(fragment.foot_html())} <%static:require_module_async module_name="js/commerce/track_ecommerce_events" class_name="TrackECommerceEvents"> var fbeLink = $("#FBE_banner"); + var welcomeLink = $("#welcome"); + var accessDeniedUpsellLink = $("#accessDeniedUpsell"); TrackECommerceEvents.trackUpsellClick(fbeLink, 'in_course_audit_access_expires', { pageName: "in_course", @@ -282,4 +284,16 @@ ${HTML(fragment.foot_html())} linkCategory: "FBE_banner" }); - \ No newline at end of file + TrackECommerceEvents.trackUpsellClick(welcomeLink, 'in_course_welcome', { + pageName: "in_course", + linkType: "link", + linkCategory: "welcome" + }); + + TrackECommerceEvents.trackUpsellClick(accessDeniedUpsellLink, 'in_course_upgrade', { + pageName: "in_course", + linkType: "link", + linkCategory: "(none)" + }); + + diff --git a/openedx/features/content_type_gating/templates/content_type_gating/access_denied_message.html b/openedx/features/content_type_gating/templates/content_type_gating/access_denied_message.html index 63086c7df5..546b647704 100644 --- a/openedx/features/content_type_gating/templates/content_type_gating/access_denied_message.html +++ b/openedx/features/content_type_gating/templates/content_type_gating/access_denied_message.html @@ -11,7 +11,7 @@ {% if not mobile_app and ecommerce_checkout_link %} - + {% trans "Upgrade to unlock" as tmsg %}{{tmsg|force_escape}} ({{min_price}}) diff --git a/openedx/features/course_experience/templates/course_experience/course-home-fragment.html b/openedx/features/course_experience/templates/course_experience/course-home-fragment.html index f0f392b786..33b2d22204 100644 --- a/openedx/features/course_experience/templates/course_experience/course-home-fragment.html +++ b/openedx/features/course_experience/templates/course_experience/course-home-fragment.html @@ -194,6 +194,7 @@ from openedx.features.course_experience.course_tools import HttpMethod var personalizedLearnerSchedulesLink = $(".personalized_learner_schedules_button"); var fbeLink = $("#FBE_banner"); + var welcomeLink = $("#welcome"); TrackECommerceEvents.trackUpsellClick(personalizedLearnerSchedulesLink, 'course_home_upgrade_shift_dates', { pageName: "course_home", @@ -201,11 +202,16 @@ from openedx.features.course_experience.course_tools import HttpMethod linkCategory: "personalized_learner_schedules" }); - TrackECommerceEvents.trackUpsellClick(fbeLink, 'course_home_audit_access_expires', { + TrackECommerceEvents.trackUpsellClick(fbeLink, 'course_home_audit_access_expires', { pageName: "course_home", linkType: "link", linkCategory: "FBE_banner" - }); + }); + TrackECommerceEvents.trackUpsellClick(welcomeLink, 'course_home_welcome', { + pageName: "course_home", + linkType: "link", + linkCategory: "welcome" + }); diff --git a/openedx/features/course_experience/tests/views/test_course_home.py b/openedx/features/course_experience/tests/views/test_course_home.py index 3824e23a61..fde5b09752 100644 --- a/openedx/features/course_experience/tests/views/test_course_home.py +++ b/openedx/features/course_experience/tests/views/test_course_home.py @@ -442,7 +442,7 @@ class TestCourseHomePageAccess(CourseHomePageTestCase): bannerText = u'''
Upgrade by {discount_expiration_date} and save {percentage}% [{strikeout_price}] -
Use code EDXWELCOME at checkout! Upgrade Now +
Use code EDXWELCOME at checkout! Upgrade Now
'''.format( discount_expiration_date=discount_expiration_date, percentage=percentage, diff --git a/openedx/features/discounts/utils.py b/openedx/features/discounts/utils.py index 5f091130c2..0a3438b099 100644 --- a/openedx/features/discounts/utils.py +++ b/openedx/features/discounts/utils.py @@ -123,7 +123,7 @@ def generate_offer_html(user, course): u'{a_open}Upgrade Now{a_close}{div_close}') message_html = HTML(offer_message).format( - a_open=HTML(u'').format( + a_open=HTML(u'').format( upgrade_link=verified_upgrade_deadline_link(user=user, course=course) ), a_close=HTML(''),