From c54f895199656bffc3b407b50cda9cb5cf5f3fa6 Mon Sep 17 00:00:00 2001
From: ichuang <ichuang@gmail.com>
Date: Tue, 5 Jun 2012 13:12:04 -0400
Subject: [PATCH 1/2] cleaned up exception handling in capa_module

---
 djangoapps/courseware/modules/capa_module.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/djangoapps/courseware/modules/capa_module.py b/djangoapps/courseware/modules/capa_module.py
index e2ad68a41e..ea6b589e38 100644
--- a/djangoapps/courseware/modules/capa_module.py
+++ b/djangoapps/courseware/modules/capa_module.py
@@ -208,7 +208,7 @@ class Module(XModule):
                 fp = StringIO.StringIO('<problem><text><font color="red" size="+2">Problem file %s is missing</font></text></problem>' % self.filename)
                 fp.name = "StringIO"
             else:
-                raise Exception,err
+                raise
         try:
             self.lcp=LoncapaProblem(fp, self.item_id, state, seed = seed, system=self.system)
         except Exception,err:
@@ -222,7 +222,7 @@ class Module(XModule):
                 fp.name = "StringIO"
                 self.lcp=LoncapaProblem(fp, self.item_id, state, seed = seed, system=self.system)
             else:
-                raise Exception,err
+                raise
 
     def handle_ajax(self, dispatch, get):
         '''
@@ -354,7 +354,7 @@ class Module(XModule):
         try:
             html = self.get_problem_html(encapsulate=False)
         except Exception,err:
-            log.error('failed to generate html, error %s' % err)
+            log.error('failed to generate html')
             raise Exception,err
 
         return json.dumps({'success': success,

From fc791ad8527b61eda6064afc3309425cfadd8650 Mon Sep 17 00:00:00 2001
From: ichuang <ichuang@gmail.com>
Date: Tue, 5 Jun 2012 13:22:24 -0400
Subject: [PATCH 2/2] more minor exception handling changes to capa_module

---
 djangoapps/courseware/modules/capa_module.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/djangoapps/courseware/modules/capa_module.py b/djangoapps/courseware/modules/capa_module.py
index ea6b589e38..cf346f700c 100644
--- a/djangoapps/courseware/modules/capa_module.py
+++ b/djangoapps/courseware/modules/capa_module.py
@@ -202,7 +202,7 @@ class Module(XModule):
         try:
             fp = self.filestore.open(self.filename)
         except Exception,err:
-            log.error('[courseware.capa.capa_module.Module.init] error %s: cannot open file %s' % (err,self.filename))
+            log.exception('[courseware.capa.capa_module.Module.init] error %s: cannot open file %s' % (err,self.filename))
             if self.DEBUG:
                 # create a dummy problem instead of failing
                 fp = StringIO.StringIO('<problem><text><font color="red" size="+2">Problem file %s is missing</font></text></problem>' % self.filename)
@@ -213,7 +213,7 @@ class Module(XModule):
             self.lcp=LoncapaProblem(fp, self.item_id, state, seed = seed, system=self.system)
         except Exception,err:
             msg = '[courseware.capa.capa_module.Module.init] error %s: cannot create LoncapaProblem %s' % (err,self.filename)
-            log.error(msg)
+            log.exception(msg)
             if self.DEBUG:
                 msg = '<p>%s</p>' % msg.replace('<','&lt;')
                 msg += '<p><pre>%s</pre></p>' % traceback.format_exc().replace('<','&lt;')