From af6d0eb145039d94749b9d52800c457dd8aede72 Mon Sep 17 00:00:00 2001 From: Anton Stupak Date: Thu, 5 Sep 2013 10:49:42 +0300 Subject: [PATCH 1/2] Fix selector. --- common/lib/xmodule/xmodule/js/src/tabs/tabs-aggregator.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/lib/xmodule/xmodule/js/src/tabs/tabs-aggregator.coffee b/common/lib/xmodule/xmodule/js/src/tabs/tabs-aggregator.coffee index 7c6e85e34b..521b19dfbc 100644 --- a/common/lib/xmodule/xmodule/js/src/tabs/tabs-aggregator.coffee +++ b/common/lib/xmodule/xmodule/js/src/tabs/tabs-aggregator.coffee @@ -9,7 +9,7 @@ class @TabsEditingDescriptor ### # hide editor/settings bar - $('.component-edit-header').hide() + @element.closest('.component-editor').find('.component-edit-header').hide() @$tabs = $(".tab", @element) @$content = $(".component-tab", @element) From d93215c0b97ae10a0a604e599c3f04f2cd3b3c2d Mon Sep 17 00:00:00 2001 From: Anton Stupak Date: Thu, 5 Sep 2013 17:02:53 +0300 Subject: [PATCH 2/2] Fix test. --- .../xmodule/js/fixtures/tabs-edit.html | 56 ++++++++++--------- .../xmodule/xmodule/js/spec/tabs/edit.coffee | 2 +- 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/common/lib/xmodule/xmodule/js/fixtures/tabs-edit.html b/common/lib/xmodule/xmodule/js/fixtures/tabs-edit.html index c83a145622..7c0f7be2b7 100644 --- a/common/lib/xmodule/xmodule/js/fixtures/tabs-edit.html +++ b/common/lib/xmodule/xmodule/js/fixtures/tabs-edit.html @@ -1,33 +1,35 @@ -
-
-
- -
-
- +
+
+
+
+ +
+
+ +
+
+ Transcripts +
+
+ Subtitles +
-
- Transcripts -
-
- Subtitles +
+
-
- -
-
-
+
-
+
+
diff --git a/common/lib/xmodule/xmodule/js/spec/tabs/edit.coffee b/common/lib/xmodule/xmodule/js/spec/tabs/edit.coffee index 734e398c74..d5502b7a29 100644 --- a/common/lib/xmodule/xmodule/js/spec/tabs/edit.coffee +++ b/common/lib/xmodule/xmodule/js/spec/tabs/edit.coffee @@ -65,7 +65,7 @@ describe "TabsEditingDescriptor", -> describe "editor/settings header", -> it "is hidden", -> - expect(@descriptor.element.find(".component-edit-header").css('display')).toEqual('none') + expect(@descriptor.element.closest(".component-editor").find(".component-edit-header")).toBeHidden() describe "TabsEditingDescriptor special save cases", -> beforeEach ->