From 5487ff590628128903b78985a101a8e16956550b Mon Sep 17 00:00:00 2001 From: Matjaz Gregoric Date: Tue, 21 Sep 2021 16:44:35 +0200 Subject: [PATCH] Fix RTL issue with capa problems (#28562) * fix: resolve styling cap RTL styling issue Margins were incorrect in the RTL version of the stylesheet. * fix: move style overrides from lms-course to capa These styles were only applied to the LTR version of the stylesheet, but we want them in the RTL version as well. --- common/lib/xmodule/xmodule/css/capa/display.scss | 7 ++++--- lms/static/sass/lms-course.scss | 14 -------------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/common/lib/xmodule/xmodule/css/capa/display.scss b/common/lib/xmodule/xmodule/css/capa/display.scss index 9fb644bce9..684b43da73 100644 --- a/common/lib/xmodule/xmodule/css/capa/display.scss +++ b/common/lib/xmodule/xmodule/css/capa/display.scss @@ -237,7 +237,8 @@ div.problem { input[type="radio"], input[type="checkbox"] { - @include margin(($baseline/4) ($baseline/2) ($baseline/4) ($baseline/4)); + @include margin($baseline/4); + @include margin-right($baseline/2); } input { @@ -288,7 +289,7 @@ div.problem { label { @include padding($baseline/2); - @include padding-left($baseline*1.9); + @include padding-left($baseline*2.3); position: relative; font-size: $base-font-size; @@ -301,7 +302,7 @@ div.problem { @include left(em(9)); position: absolute; - top: em(9); + top: 0.35em; width: $baseline*1.1; height: $baseline*1.1; z-index: 1; diff --git a/lms/static/sass/lms-course.scss b/lms/static/sass/lms-course.scss index 809aa4be5a..6069fc5269 100644 --- a/lms/static/sass/lms-course.scss +++ b/lms/static/sass/lms-course.scss @@ -24,17 +24,3 @@ } } } - -// Extra mfe theme-specific rules. -// Move this to a separate file in case more mfe specific rules need to be a added -.xmodule_display.xmodule_ProblemBlock div.problem { - .choicegroup { - label { - padding-left: $baseline*2.3; - } - - input[type="radio"], input[type="checkbox"] { - top: 0.35em; - } - } -}